Kernel Bug Tracker – Bug 5067
[Patch] asus_acpi hotkeys do not work on Samsung P30
Last modified: 2010-10-08 18:17:12 UTC
Distribution: debian sarge
Hardware Environment: Samsung P30
I get an OOPS if I try to load asus_acpi as modul. After a little googling I find
this link with the a patch wich solved my problem. Applying this made my hotkeys
Created attachment 5642 [details]
Here is the patch mentioned in the URL
Would you mind checking this link:
The patch mentioned in comment 6 in #5092
(http://bugzilla.kernel.org/attachment.cgi?id=5982&action=view) didn't fix my
problem, but the tip to specify acpi=strict as kernel parameter helped me and I
was able to boot my notebook (asus_acpi is compiled in; the notebook will boot
if asus_acpi is compiled as a module, but I get an oops).
This seems strange because the patch does specify acpi=strict inside asus_acpi.c.
I even tried to move the statement [...] acpi_strict = 1; a little higher in
the function (after the declaration of acpi_status status;) but it didn't
help. Tomorrow I'll try to have the acpi_strict=1; for the whole function. If
this will fix my problem you'll hear from me :-)
OK, my bad, I missed the fact that acpi_gbl_enable_interpreter_slack (which is
what we're after) is set only at boot. Working that out would require either a
few changes to drivers/acpi/dispatcher/dsutils.c or exporting
*** Bug 5092 has been marked as a duplicate of this bug. ***
Created attachment 6006 [details]
This is functionally identical to the first patch, but the comments are updated
Please note that this patch is still only a workaround and I believe we need a
mechanism to make the interpreter behave deterministically (i.e. disable
implicit return) at run-time (just as we can disable higher Cx states).
I wanted to install the new kernel 2.6.14. Without the patch I still get the
oops. But I think there were changes to the asus_acpi.c because the patch does
root@hostname:/usr/src# patch linux-2.6.14/drivers/acpi/asus_acpi.c asus_acpi.patch
patching file linux-2.6.14/drivers/acpi/asus_acpi.c
Hunk #1 FAILED at 990.
Hunk #2 FAILED at 1019.
2 out of 2 hunks FAILED -- saving rejects to file
Created attachment 6418 [details]
Fix for 2.6.14
New patch for 2.6.14, got it from Christian Aichinger (so all credits to him).
The new fix for 2.6.14 is working. Thank you! (VERIFIED)
Created attachment 6879 [details]
my previous patch rediffed, updated
Rediffed against 2.6.15-rc6, also plugs a leak my previous patch introduced.
Note: I still prefer this patch from the other one.
I just compiled kernel 126.96.36.199 with your new patch and it works without problems.
Will this patch be integrated into the kernel sources? Because without the patch
I still get the kernel oops.
applied patch in comment #10 to acpi-test tree
shipped in linux-2.6.16