Bug 214579 - Build warnings in current libcap-2.59 tree
Summary: Build warnings in current libcap-2.59 tree
Status: RESOLVED CODE_FIX
Alias: None
Product: Tools
Classification: Unclassified
Component: libcap (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: Andrew G. Morgan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-29 23:15 UTC by Andrew G. Morgan
Modified: 2021-09-30 04:45 UTC (History)
1 user (show)

See Also:
Kernel Version: n/a
Subsystem:
Regression: No
Bisected commit-id:


Attachments

Description Andrew G. Morgan 2021-09-29 23:15:35 UTC
Apply this diff:

--- a/google3/third_party/libcap/doc/cap_launch.3
+++ b/google3/third_party/libcap/doc/cap_launch.3
@@ -86,7 +86,7 @@ this would be to allocate detail as follows:
    printf("launcher callback set detail to %d\\n", *detail);
    munmap(detail, sizeof(int));
 
-.if
+.fi
 .PP
 Unless modified by the callback function, the launched code will
 execute with the capability and other security context of the
======

Silence these C compilation warnings from clang (-Wunreachable-code):

- libcap/libcap/cap_proc.c:1025
- libcap/progs/capshdoc.h:377

Address these Go vet warnings:

- libcap/cap/file.go:353
  comment on exported var MinExtFlagSize should be of the form "MinExtFlagSize ..."
- libcap/psx/psx.go:11
  comment on exported function Syscall3 should be of the form "Syscall3 ..."
- libcap/psx/psx.go:16
  comment on exported function Syscall6 should be of the form "Syscall6 ..."

Note You need to log in before you can comment on or make changes to this bug.