Bug 92071 - [PATCH?] ocfs2 (o2cb default mode) ignores umask
Summary: [PATCH?] ocfs2 (o2cb default mode) ignores umask
Status: NEW
Alias: None
Product: File System
Classification: Unclassified
Component: ocfs2 (show other bugs)
Hardware: All Linux
: P1 high
Assignee: fs_ocfs2
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-26 15:17 UTC by Dzianis Kahanovich
Modified: 2016-03-20 11:17 UTC (History)
1 user (show)

See Also:
Kernel Version: 3.18.3
Subsystem:
Regression: No
Bisected commit-id:

Attachments
add ocfs2 umask support (514 bytes, patch)
2015-01-26 15:17 UTC, Dzianis Kahanovich 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Description Dzianis Kahanovich 2015-01-26 15:17:57 UTC 
Created attachment 164791 [details]
add ocfs2 umask support

ocfs2 in default vanilla (o2cb, no acl/noacl mount flags) ignores umask. Found  & fixed in 3.18.3, tested linux-3.19.0-rc5-next-20150123-dirty - all same. In old versions visually present "& ~current_umask()" in acl.c, removed by commit 702e5bc68ad2c02f1b12b53ef7093074af9d2441 "ocfs2: use generic posix ACL infrastructure" 3.13.0 (no compiling and run +-this versions now, so bisected not complete).

Fixed in "single point" manner, working for me, but looks too different with pre-3.13. Also I don't understang how umask interoperated with acl's. But proposing patch...
Note You need to log in before you can comment on or make changes to this bug.