An SMB mount to a Windows XP machine in my fstab no longer works. It last worked with 6.0.9. fstab line: //server/D /remote/server/D cifs noauto,_netdev,username=example,password=example,uid=1000,vers=1.0,nomultichannel 0 0 When I attempt to mount this now, I get the following error: mount error(20): Not a directory dmesg shows: CIFS: VFS: bogus file nlink value 0
(In reply to Kim Scarborough from comment #0) > It last worked with 6.0.9. Do you mean it broke with later 6.0.y kernels? Or did you switch to 6.1 after that?
I went to 6.1 after 6.0.9. Sorry, I should have made that clear.
Hi Kim, Thanks for the report. Could you please try this patch[1] and see if it works for you? Please make sure that you also have 9ee2afe5207b ("cifs: prevent copying past input buffer boundaries") [1] https://pc.cjr.nz/smb1.diff
I applied the patch and installed the new kernel, but I'm getting the same error.
Thanks for testing it. In this case, please generate verbose logs and network trace # umount any existing shares dmesg --clear echo 'module cifs +p' > /sys/kernel/debug/dynamic_debug/control echo 'file fs/cifs/* +p' > /sys/kernel/debug/dynamic_debug/control echo 1 > /proc/fs/cifs/cifsFYI echo 1 > /sys/module/dns_resolver/parameters/debug tcpdump -s 0 -w trace.pcap port 445 & pid=$! sleep 3 mount.cifs ... sleep 3 kill $pid dmesg > trace.log cat /proc/fs/cifs/dfscache >> trace.log and then send trace.log and trace.pcap files.
Created attachment 303540 [details] Log file
Created attachment 303541 [details] PCAP file
Created attachment 303542 [details] patch 1
Created attachment 303543 [details] patch 2
Hi Jim, Thanks for providing the logs and trace. Could you please try the two attached patches instead?
s/Jim/Kim/
Those fixed it. Thanks!
FYI, fixes[1] sent upstream already. [1] https://lore.kernel.org/linux-cifs/20230107200134.4822-1-pc@cjr.nz/T/#t
(In reply to Paulo Alcantara from comment #13) > FYI, fixes[1] sent upstream already. > [1] https://lore.kernel.org/linux-cifs/20230107200134.4822-1-pc@cjr.nz/T/#t FWIW, that "Bug: https://bugzilla.kernel.org/show_bug.cgi?id=216881" should have been "Link: https://bugzilla.kernel.org/show_bug.cgi?id=216881" (see Documentation/process/submitting-patches.rst , Documentation/process/5.Posting.rst or mails like these: https://lore.kernel.org/all/CAHk-=wjMmSZzMJ3Xnskdg4+GGz=5p5p+GSYyFBTh0f-DgvdBWg@mail.gmail.com/ https://lore.kernel.org/all/CAHk-=wgs38ZrfPvy=nOwVkVzjpM3VFU1zobP37Fwd_h9iAD5JQ@mail.gmail.com/ https://lore.kernel.org/all/CAHk-=wjxzafG-=J8oT30s7upn4RhBs6TX-uVFZ5rME+L5_DoJA@mail.gmail.com/ )
(In reply to The Linux kernel's regression tracker (Thorsten Leemhuis) from comment #14) > (In reply to Paulo Alcantara from comment #13) > > FYI, fixes[1] sent upstream already. > > [1] https://lore.kernel.org/linux-cifs/20230107200134.4822-1-pc@cjr.nz/T/#t > > FWIW, that "Bug: https://bugzilla.kernel.org/show_bug.cgi?id=216881" should > have been "Link: https://bugzilla.kernel.org/show_bug.cgi?id=216881" (see > Documentation/process/submitting-patches.rst , > Documentation/process/5.Posting.rst or mails like these: > > https://lore.kernel.org/all/CAHk-=wjMmSZzMJ3Xnskdg4+GGz=5p5p+GSYyFBTh0f- > DgvdBWg@mail.gmail.com/ > https://lore.kernel.org/all/CAHk- > =wgs38ZrfPvy=nOwVkVzjpM3VFU1zobP37Fwd_h9iAD5JQ@mail.gmail.com/ > https://lore.kernel.org/all/CAHk-=wjxzafG-=J8oT30s7upn4RhBs6TX- > uVFZ5rME+L5_DoJA@mail.gmail.com/ ) Thanks! I'll ask Steve to fix those before merging.