Bug 214165 - Missing clflush before RECEIVE_UPDATE_DATA
Summary: Missing clflush before RECEIVE_UPDATE_DATA
Status: NEW
Alias: None
Product: Virtualization
Classification: Unclassified
Component: kvm (show other bugs)
Hardware: x86-64 Linux
: P1 normal
Assignee: virtualization_kvm
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-24 11:52 UTC by Masahiro Kozuka
Modified: 2021-09-14 00:30 UTC (History)
1 user (show)

See Also:
Kernel Version: 5.13.12
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add the missing sev_clflush_pages() (490 bytes, text/plain)
2021-08-24 11:52 UTC, Masahiro Kozuka 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Masahiro Kozuka 2021-08-24 11:52:46 UTC 
Created attachment 298457 [details]
Add the missing sev_clflush_pages()

In sev_receive_update_data(), sev_clflush_pages() is not called b/w sev_pin_memory() and RECEIVE_UPDATE_DATA. Because of this missing, we will often see the pre-written contents in the memory updated by RECEIVE_UPDATE_DATA. I guess that we should call sev_clflush_pages() as LAUNCH_UPDATE_DATA.
Comment 1 Sean Christopherson 2021-09-13 23:06:46 UTC 
If you can provided a Signed-off-by, I'll happily write a changelog and post the patch on your behalf.  Thanks!
Comment 2 Masahiro Kozuka 2021-09-14 00:30:40 UTC 
(In reply to Sean Christopherson from comment #1)
> If you can provided a Signed-off-by, I'll happily write a changelog and post
> the patch on your behalf.  Thanks!

Thabk you for your reply. Please use Signed-off-by: Masahiro Kozuka <masa.koz@kozuka.jp>
Note You need to log in before you can comment on or make changes to this bug.