Bug 207607 - RTL8822C: rtw88: "failed to wait firmware completion" on 5.6+
Summary: RTL8822C: rtw88: "failed to wait firmware completion" on 5.6+
Status: RESOLVED CODE_FIX
Alias: None
Product: Networking
Classification: Unclassified
Component: Wireless (show other bugs)
Hardware: All Linux
: P1 high
Assignee: networking_wireless@kernel-bugs.osdl.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-06 17:50 UTC by Alexander
Modified: 2020-05-07 22:24 UTC (History)
2 users (show)

See Also:
Kernel Version: 5.6.x
Subsystem:
Regression: No
Bisected commit-id:


Attachments
attachment-21812-0.html (1.74 KB, text/html)
2020-05-07 03:53 UTC, Alexander
Details

Description Alexander 2020-05-06 17:50:02 UTC
I am new to bug reporting, so please, bear with me. 

5.6+ kernels all result in my wifi not working. 

Currently running 5.5.19 and it works. 

5.5.17 kernel:

https://hastebin.com/jetefuvune

and on the 5.6.4 kernel:

https://hastebin.com/ofafanalew

Let me know if you need anything more from me. I believe Johannes Berg is the man to contact regarding iwlwifi, so please tag him.
Comment 1 Emmanuel Grumbach 2020-05-06 19:38:09 UTC
The problem is that your device is not an Intel one and iwlwifi is only related to Intel devices.
You have  realtek device.
Comment 2 Brian Norris 2020-05-06 19:46:55 UTC
This might possibly be a regression in this:

c8e5695eae99 rtw88: load wowlan firmware if wowlan is supported
Comment 3 Alexander 2020-05-06 22:32:40 UTC
For whatever reason both of the linked hastebins have suddenly begun showing up empty or not properly loading when I click them... let me know if you're also having difficulties with reading them. 

You could perhaps assist me a bit in debugging and solving my problem?
Comment 4 Yen-Hsuan Chuang 2020-05-07 02:09:28 UTC
It's because rtw88 added WOW (wake on wireless LAN) support, and WOW requires another firmware "rtw8822c_wow_fw.bin".

You can get it on linux-firmware/rtw88 [1], and put it under /lib/firmware/rtw88/ . Reboot your device, that firmware should be loaded successfully.

Besides, I think we need a way to let destributions to package the firmware to prevent something like this. But not sure how to do it the best way.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git
Comment 5 Alexander 2020-05-07 03:53:19 UTC
Created attachment 288971 [details]
attachment-21812-0.html

I will update the RTW88 firmware and hopefully that does the job. How would
I go about checking for other possibly missing firmwares?

On Wed, 6 May 2020, 21:46 , <bugzilla-daemon@bugzilla.kernel.org> wrote:

> https://bugzilla.kernel.org/show_bug.cgi?id=207607
>
> Brian Norris (briannorris@chromium.org) changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>                  CC|                            |briannorris@chromium.org
>             Summary|iwlwifi still broken on     |RTL8822C: rtw88: "failed
> to
>                    |5.6+                        |wait firmware completion"
>                    |                            |on 5.6+
>
> --- Comment #2 from Brian Norris (briannorris@chromium.org) ---
> This might possibly be a regression in this:
>
> c8e5695eae99 rtw88: load wowlan firmware if wowlan is supported
>
> --
> You are receiving this mail because:
> You reported the bug.
Comment 6 Yen-Hsuan Chuang 2020-05-07 04:00:54 UTC
That's something I'd like to know, I think that's distro's job to make sure the firmware is packed.
Comment 7 Brian Norris 2020-05-07 19:47:46 UTC
It's a desirable goal to not make the entire driver fail just because an optional firmware binary is missing. IIUC, rtw88 can (or, it obviously did on kernel v5.5) work just fine without WoWLAN firmware -- it just won't support WoWLAN.

The packaging question is a different story, and I expect either
(a) the reporter is running a bleeding edge distro, and said bleeing-edge distro should package that firmware soon or
(b) the reporter is testing an unsupported kernel on a non-bleeding-edge distro, and the onus is on the reporter to then acquire the appropriate firmware.

@Reporter: can you provide more info? What distro are you using? Also, bugzilla has an attachment function, so logs can be put there, instead of on some website I've never heard of (hastebin?) that may or may not have any reliability.
Comment 8 Alexander 2020-05-07 22:03:32 UTC
I am running Linux Mint 19.2 Tina. 

Currently 5.5.19-050519-generic.

The hastebin site does seem to have reset and I apologize for the terrible reporting on my part. If you give me the commands, I will post the output. 

I used "sudo lspci -v -s 02:00" last time and it currently outputs:

02:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller (rev 15)
        Subsystem: ASUSTeK Computer Inc. RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller
        Flags: bus master, fast devsel, latency 0, IRQ 53
        I/O ports at e000 [size=256]
        Memory at f7804000 (64-bit, non-prefetchable) [size=4K]
        Memory at f7800000 (64-bit, non-prefetchable) [size=16K]
        Capabilities: [40] Power Management version 3
        Capabilities: [50] MSI: Enable- Count=1/1 Maskable- 64bit+
        Capabilities: [70] Express Endpoint, MSI 01
        Capabilities: [b0] MSI-X: Enable+ Count=4 Masked-
        Capabilities: [100] Advanced Error Reporting
        Capabilities: [140] Virtual Channel
        Capabilities: [160] Device Serial Number 01-00-00-00-68-4c-e0-00
        Capabilities: [170] Latency Tolerance Reporting
        Capabilities: [178] L1 PM Substates
        Kernel driver in use: r8169
        Kernel modules: r8169
Comment 9 Alexander 2020-05-07 22:18:46 UTC
uname -r
5.6.11-050611-generic

Wifi now works again on this system... but makes me wonder much else firmware might be missing :)
Comment 10 Brian Norris 2020-05-07 22:24:00 UTC
Just for the record:

> "sudo lspci -v -s 02:00"

That's displaying your Ethernet controller, not your WiFi.

Glad your system is fixed, presumably by installing the WoW firmware manually.

(I still think rtw88 should be fixed to make that firmware optional.)

Note You need to log in before you can comment on or make changes to this bug.