Bug 205839 - backport-iwlwifi: stable patch commit 55667441c84f causes dkms to hang system while connecting wifi
Summary: backport-iwlwifi: stable patch commit 55667441c84f causes dkms to hang system...
Status: NEW
Alias: None
Product: Networking
Classification: Unclassified
Component: Wireless (show other bugs)
Hardware: x86-64 Linux
: P1 high
Assignee: networking_wireless@kernel-bugs.osdl.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-12 02:52 UTC by You-Sheng Yang
Modified: 2022-02-19 23:49 UTC (History)
3 users (show)

See Also:
Kernel Version: 5.3.10
Subsystem:
Regression: No
Bisected commit-id:

Attachments
proposed patch (3.94 KB, patch)
2019-12-12 02:59 UTC, You-Sheng Yang 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Description You-Sheng Yang 2019-12-12 02:52:36 UTC 
Commit 55667441c84f ("net/flow_dissector: switch to siphash")[1] changes member field data type of `struct fq`, which backport-iwlwifi carries its own copy that is currently not yet updated in version 8042. As a result, it causes some unexpected behavior when skb_get_hash_perturb() is called, and in our cases it causes system hang while NetworkManager is trying to associate preconfigured WiFi base stations before logging in GDM.

This affects all models of WiFi hw whenever this backport-iwlwifi driver is used.

This can be reproduced on all kernel versions with this commit backported, namely kernels >= 5.3.10, 4.19.83, 4.14.153, 4.9.200, 4.4.200. For Ubuntu, it means Focal 5.4 kernels, Eoan >= 5.3.0-24, Disco >= 5.0.0-38, Bionic >= 4.15.0-73, OEM >= 4.15.0-1066, OEM-OSP1 >= 5.0.0-1032.

It's already tracked in Ubuntu Launchpad in bug-1855825[2], as well as my personal DKMS packaging in GitLab[3].

[1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=55667441c84fa5e0911a0aac44fb059c15ba6da2
[2]: https://bugs.launchpad.net/ubuntu/+source/backport-iwlwifi-dkms/+bug/1855825
[3]: https://gitlab.com/vicamo/backport-iwlwifi-dkms/issues/7
Comment 1 You-Sheng Yang 2019-12-12 02:59:54 UTC 
Created attachment 286255 [details]
proposed patch

This patch applies to latest version 8042 of backport-iwlwifi from https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/backport-iwlwifi.git .

Please find https://launchpad.net/~vicamo/+archive/ubuntu/ppa-1855825 for prebuilt DKMS deb PPA.
Comment 2 Marcin Bajor 2022-02-19 23:48:18 UTC 
Additional Info: If this error already occurs. I am not able to use WiFi to connect to AP. (var_log_messages_wifi_connetion attached)
Comment 3 Marcin Bajor 2022-02-19 23:49:43 UTC 
I'm so sorry. Please ignore the above message. Wrong issue.
Note You need to log in before you can comment on or make changes to this bug.