Bug 204997 - fsck.xfs prints a vague message "XFS file system" when skipping a boot time check
Summary: fsck.xfs prints a vague message "XFS file system" when skipping a boot time c...
Status: NEW
Alias: None
Product: File System
Classification: Unclassified
Component: XFS (show other bugs)
Hardware: All Linux
: P1 low
Assignee: FileSystem/XFS Default Virtual Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-25 17:51 UTC by Steve Bonds
Modified: 2019-09-25 17:51 UTC (History)
0 users

See Also:
Kernel Version: 5.4
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Suggested patch to improve the error message seen on boot. (440 bytes, text/plain)
2019-09-25 17:51 UTC, Steve Bonds 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Steve Bonds 2019-09-25 17:51:35 UTC 
Created attachment 285173 [details]
Suggested patch to improve the error message seen on boot.

When an XFS filesystems is configured to be checked on boot via the /etc/fstab, the /usr/sbin/fsck.xfs is called. It does nothing but print "XFS file system" which can mislead admins into thinking the filesytem was checked when it has not been.

This was previously reported via RedHat bug https://bugzilla.redhat.com/show_bug.cgi?id=1546294 and is a minor issue.

Steps to Reproduce:
1. Change the "0 0" in /etc/fstab for /home to "0 1"
2. Reboot and watch console messages

Actual results:

Observe "Started file system check on /dev/mapper/<name of home LV>"

Observe "systemd-fsck[<PID>]: /sbin/fsck.xfs: XFS file system"

Expected results:

Observe "systemd-fsck[<PID>]: /sbin/fsck.xfs: XFS file system checks always skipped on boot"

Or some other message to make it clear that the check was 1) skipped and 2) this was intentional
Note You need to log in before you can comment on or make changes to this bug.