Bug 191471 - Mp2Sas and Mpt3Sas (now mpxsas) drivers are spinning forever in the IRQ handler under load condition
Summary: Mp2Sas and Mpt3Sas (now mpxsas) drivers are spinning forever in the IRQ handl...
Status: NEW
Alias: None
Product: IO/Storage
Classification: Unclassified
Component: SCSI (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: linux-scsi@vger.kernel.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-29 15:16 UTC by Sinan Kaya
Modified: 2017-04-03 15:31 UTC (History)
3 users (show)

See Also:
Kernel Version: 4.7
Subsystem:
Regression: No
Bisected commit-id:


Attachments
Propsed fix (3.50 KB, patch)
2017-04-03 15:31 UTC, Timur Tabi
Details | Diff

Description Sinan Kaya 2016-12-29 15:16:46 UTC
When there are a lot of IO requests queued for the HW, the IRQ handler of the mpxsas driver spins forever until all requests are serviced. 

Spinning in the IRQ handler forever is a bad design and causes stalls on the other cores that is unrelated to this request.

A simple solution has been posted here but rejected by the maintainer as the maintainer has been looking to offload only the slow path to task context.

https://patchwork.kernel.org/patch/7579951/

Further requests for details to resolve the issue has been unanswered.

Logging the issue here for awareness.
Comment 1 Timur Tabi 2017-04-03 15:31:37 UTC
Created attachment 255737 [details]
Propsed fix

Note You need to log in before you can comment on or make changes to this bug.