Created attachment 192221 [details] config-4.1.10 When trying to load /sbin/modprobe ghash_clmulni_intel it gives back at the terminal; invalid argument This does not happen for me using 4.1.10 There seems to be a bug that has been introduced here? I'm attaching my 4.1.10 config, it's the same that I used for 4.1.12
This is also happening in 4.1.13
Please help test the fix at: https://lkml.org/lkml/2015/11/29/85 This could be a dup of Bug 108151 Thanks
When applying the patches I'm getting this output; patch unexpectedly ends in middle of line patching file crypto/cryptd.c Hunk #1 succeeded at 628 (offset -9 lines). patch unexpectedly ends in middle of line patching file arch/x86/crypto/ghash-clmulni-intel_glue.c patch unexpectedly ends in middle of line Can we get these cleaned up? thanks
Created attachment 196501 [details] patch The patch to fix the bug.
(In reply to KernelBug from comment #3) > When applying the patches I'm getting this output; > > patch unexpectedly ends in middle of line > > > patching file crypto/cryptd.c > Hunk #1 succeeded at 628 (offset -9 lines). > patch unexpectedly ends in middle of line > > > patching file arch/x86/crypto/ghash-clmulni-intel_glue.c > patch unexpectedly ends in middle of line > > > Can we get these cleaned up? > > thanks It's probably because you've cut/paste the code in Windows and it contains DOS CRLF. I've attached the patch. (The code is now already merged in the crypto dev git tree)
I clicked on your name listed twice, then I clicked; 'get diff 1' then it loaded the patch and I then did 'ctrl s' to download it, and I renamed it blahblah.diff Hmmm
The patch appears to be working! No smoke seen yet! LOL :)
by the way THANKS!
This is still a problem in 4.1.14. I hope this is going to get committed soon to LTS?
Actually this just needs to get fixed in the latest kernels. Seen this in 4.3.2 also...
It's already merged in the crypto maintainer Herbert Xu's tree: http://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git It'll take some time to get into Linus's tree.
It also just appeared now in 4.1.16
Can someone please tell me what kernel version this is being merged into? The patch also needs applying in 4.4x thanks
Linux 4.4-rc4 commit 1a07834024dfca5c4bed5de8f8714306e0a11836 Author: Wang, Rui Y <rui.y.wang@intel.com> Date: Sun Nov 29 22:45:34 2015 +0800 crypto: cryptd - Assign statesize properly commit 3a020a723c65eb8ffa7c237faca26521a024e582 Author: Wang, Rui Y <rui.y.wang@intel.com> Date: Sun Nov 29 22:45:33 2015 +0800 crypto: ghash-clmulni - Fix load failure
@ Rui Wang, I don't understand your reply? All I know is you committed this, but what kernel version(s) did it take effect in? Because I still needed to apply the patches in 4.4.12...
It's in upstream kernel from git.kernel.org (v4.4-rc4). But it may not be in a stable kernel or a distribution like Ubuntu.
Will it eventually be merged to a stable kernel?