Bug 82321

Summary:	drivers/s390/block/dasd.c: 2 * bad if test ?
Product:	Drivers	Reporter:	David Binderman (dcb314)
Component:	Other	Assignee:	drivers_other
Status:	NEW ---
Severity:	normal
Priority:	P1
Hardware:	S390-31
OS:	Linux
Kernel Version:	linux_next_20140813	Subsystem:
Regression:	No	Bisected commit-id:

Description David Binderman 2014-08-13 11:44:53 UTC

[linux-next/drivers/s390/block/dasd.c:2321]: (warning) Comparison of a boolean expression with an integer other than 0 or 1.
[linux-next/drivers/s390/block/dasd.c:2322]: (warning) Comparison of a boolean expression with an integer other than 0 or 1.

                if (!cqr->status == DASD_CQR_TERMINATED &&
                    !cqr->status == DASD_CQR_NEED_ERP)

Maybe

                if (cqr->status != DASD_CQR_TERMINATED ||
                    cqr->status != DASD_CQR_NEED_ERP)

was intended.