Bug 82321 - drivers/s390/block/dasd.c: 2 * bad if test ?
Summary: drivers/s390/block/dasd.c: 2 * bad if test ?
Status: NEW
Alias: None
Product: Drivers
Classification: Unclassified
Component: Other (show other bugs)
Hardware: S390-31 Linux
: P1 normal
Assignee: drivers_other
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-13 11:44 UTC by David Binderman
Modified: 2014-08-13 11:44 UTC (History)
0 users

See Also:
Kernel Version: linux_next_20140813
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description David Binderman 2014-08-13 11:44:53 UTC 
[linux-next/drivers/s390/block/dasd.c:2321]: (warning) Comparison of a boolean expression with an integer other than 0 or 1.
[linux-next/drivers/s390/block/dasd.c:2322]: (warning) Comparison of a boolean expression with an integer other than 0 or 1.

                if (!cqr->status == DASD_CQR_TERMINATED &&
                    !cqr->status == DASD_CQR_NEED_ERP)

Maybe

                if (cqr->status != DASD_CQR_TERMINATED ||
                    cqr->status != DASD_CQR_NEED_ERP)

was intended.
Note You need to log in before you can comment on or make changes to this bug.