Bug 82021
| Summary: | disk-io.c open_ctree() unnecessary double check | ||
|---|---|---|---|
| Product: | File System | Reporter: | Maks Naumov (maksqwe1) |
| Component: | btrfs | Assignee: | David Sterba (dsterba) |
| Status: | RESOLVED CODE_FIX | ||
| Severity: | normal | CC: | dsterba, szg00000 |
| Priority: | P1 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Kernel Version: | 3.16.0 | Subsystem: | |
| Regression: | No | Bisected commit-id: | |
There's no file with name disk_io.c in v3.16 checkout and in linux-next tree. Please update your report with exact actual info, otherwise please close ticket. Sorry, correct path is "./fs/btrfs/disk-io.c" Regression from this https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/fs/btrfs/disk-io.c?id=a79b7d4b3e8118f265dcb4bdf9a572c392f02708 commit Thanks for report, patch submitted, see "[PATCH] btrfs: Drop stray check of fixup_workers creation". Merged as 56094eecd32cbb80d0, in 3.18. |
disk_io.c 2603 if (!(fs_info->workers && fs_info->delalloc_workers && fs_info->submit_workers && fs_info->flush_workers && fs_info->endio_workers && fs_info->endio_meta_workers && fs_info->endio_meta_write_workers && fs_info->endio_write_workers && fs_info->endio_raid56_workers && fs_info->endio_freespace_worker && fs_info->rmw_workers && fs_info->caching_workers && fs_info->readahead_workers && fs_info->fixup_workers && fs_info->delayed_workers && // <=== fs_info->fixup_workers && fs_info->extent_workers && // <=== fs_info->qgroup_rescan_workers)) { err = -ENOMEM; goto fail_sb_buffer; }