Bug 82021 - disk-io.c open_ctree() unnecessary double check
Summary: disk-io.c open_ctree() unnecessary double check
Status: RESOLVED CODE_FIX
Alias: None
Product: File System
Classification: Unclassified
Component: btrfs (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: David Sterba
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-09 10:53 UTC by Maks Naumov
Modified: 2019-05-21 14:05 UTC (History)
2 users (show)

See Also:
Kernel Version: 3.16.0
Subsystem:
Regression: No
Bisected commit-id:


Attachments

Description Maks Naumov 2014-08-09 10:53:29 UTC
disk_io.c 2603

if (!(fs_info->workers && fs_info->delalloc_workers &&
  fs_info->submit_workers && fs_info->flush_workers &&
  fs_info->endio_workers && fs_info->endio_meta_workers &&
  fs_info->endio_meta_write_workers &&
  fs_info->endio_write_workers && fs_info->endio_raid56_workers &&
  fs_info->endio_freespace_worker && fs_info->rmw_workers &&
  fs_info->caching_workers && fs_info->readahead_workers &&
  fs_info->fixup_workers && fs_info->delayed_workers &&  // <===
  fs_info->fixup_workers && fs_info->extent_workers &&   // <===
  fs_info->qgroup_rescan_workers)) {
    err = -ENOMEM;
    goto fail_sb_buffer;
}
Comment 1 Andrey Utkin 2014-08-09 11:07:01 UTC
There's no file with name disk_io.c in v3.16 checkout and in linux-next tree.
Please update your report with exact actual info, otherwise please close ticket.
Comment 2 Maks Naumov 2014-08-09 11:11:33 UTC
Sorry, correct path is "./fs/btrfs/disk-io.c"
Comment 4 Andrey Utkin 2014-08-09 11:52:25 UTC
Thanks for report, patch submitted, see "[PATCH] btrfs: Drop stray check of fixup_workers creation".
Comment 5 David Sterba 2019-05-21 12:36:09 UTC
Merged as 56094eecd32cbb80d0, in 3.18.

Note You need to log in before you can comment on or make changes to this bug.