Bug 80581

Summary: fs/ubifs/{sb,super}.c: two pointless tests ?
Product: File System Reporter: David Binderman (dcb314)
Component: OtherAssignee: fs_other
Status: NEW ---    
Severity: low CC: andrey_utkin, szg00000
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 3.16-rc5 Subsystem:
Regression: No Bisected commit-id:

Description David Binderman 2014-07-18 10:08:08 UTC
1.

[linux-3.16-rc5/fs/ubifs/sb.c:450]: (style) Checking if unsigned variable 'default_compr' is less than zero.

    if (c->default_compr < 0 || c->default_compr >= UBIFS_COMPR_TYPES_CNT) {

2.

[linux-3.16-rc5/fs/ubifs/super.c:78]: (style) Checking if unsigned variable 'compr_type' is less than zero.

    if (ui->compr_type < 0 || ui->compr_type >= UBIFS_COMPR_TYPES_CNT) {
Comment 1 Andrey Utkin 2014-07-18 15:49:38 UTC
Thanks. https://patchwork.kernel.org/patch/4586111/