Bug 80581 - fs/ubifs/{sb,super}.c: two pointless tests ?
Summary: fs/ubifs/{sb,super}.c: two pointless tests ?
Status: NEW
Alias: None
Product: File System
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All Linux
: P1 low
Assignee: fs_other
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-18 10:08 UTC by David Binderman
Modified: 2016-03-20 11:25 UTC (History)
2 users (show)

See Also:
Kernel Version: 3.16-rc5
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description David Binderman 2014-07-18 10:08:08 UTC 
1.

[linux-3.16-rc5/fs/ubifs/sb.c:450]: (style) Checking if unsigned variable 'default_compr' is less than zero.

    if (c->default_compr < 0 || c->default_compr >= UBIFS_COMPR_TYPES_CNT) {

2.

[linux-3.16-rc5/fs/ubifs/super.c:78]: (style) Checking if unsigned variable 'compr_type' is less than zero.

    if (ui->compr_type < 0 || ui->compr_type >= UBIFS_COMPR_TYPES_CNT) {
Comment 1 Andrey Utkin 2014-07-18 15:49:38 UTC 
Thanks. https://patchwork.kernel.org/patch/4586111/
Note You need to log in before you can comment on or make changes to this bug.