Bug 80451

Summary:	message/i2o/i2o_block.c:674: pointless test ?
Product:	Drivers	Reporter:	David Binderman (dcb314)
Component:	Other	Assignee:	drivers_other
Status:	NEW ---
Severity:	low	CC:	andrey_utkin
Priority:	P1
Hardware:	All
OS:	Linux
Kernel Version:	3.16-rc5	Subsystem:
Regression:	No	Bisected commit-id:

Description David Binderman 2014-07-17 12:45:45 UTC

[linux-3.16-rc5/drivers/message/i2o/i2o_block.c:674]: (style) Checking if unsigned variable 'arg' is less than zero.

Source code is

        if (arg < 0 || arg > CACHE_SMARTFETCH)
            break;
but

static int i2o_block_ioctl(struct block_device *bdev, fmode_t mode,
               unsigned int cmd, unsigned long arg)

Comment 1 Andrey Utkin 2014-07-17 14:06:22 UTC

Thanks, patch submitted: https://patchwork.kernel.org/patch/4575571/