Bug 80451 - message/i2o/i2o_block.c:674: pointless test ?
Summary: message/i2o/i2o_block.c:674: pointless test ?
Status: NEW
Alias: None
Product: Drivers
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All Linux
: P1 low
Assignee: drivers_other
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-17 12:45 UTC by David Binderman
Modified: 2014-07-17 14:06 UTC (History)
1 user (show)

See Also:
Kernel Version: 3.16-rc5
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description David Binderman 2014-07-17 12:45:45 UTC 
[linux-3.16-rc5/drivers/message/i2o/i2o_block.c:674]: (style) Checking if unsigned variable 'arg' is less than zero.

Source code is

        if (arg < 0 || arg > CACHE_SMARTFETCH)
            break;
but

static int i2o_block_ioctl(struct block_device *bdev, fmode_t mode,
               unsigned int cmd, unsigned long arg)
Comment 1 Andrey Utkin 2014-07-17 14:06:22 UTC 
Thanks, patch submitted: https://patchwork.kernel.org/patch/4575571/
Note You need to log in before you can comment on or make changes to this bug.