Bug 80441

Summary:	drivers/hsi/controllers: 2 * pointless test ?
Product:	Drivers	Reporter:	David Binderman (dcb314)
Component:	Other	Assignee:	drivers_other
Status:	NEW ---
Severity:	normal	CC:	andrey_utkin
Priority:	P1
Hardware:	All
OS:	Linux
Kernel Version:	3.16-rc5	Subsystem:
Regression:	No	Bisected commit-id:

Description David Binderman 2014-07-17 12:41:26 UTC

1.

[linux-3.16-rc5/drivers/hsi/controllers/omap_ssi.c:357]: (style) Checking if unsigned variable 'gdd_irq' is less than zero.

Source code is

    omap_ssi->gdd_irq = platform_get_irq_byname(pd, "gdd_mpu");
    if (omap_ssi->gdd_irq < 0) {

2.

[linux-3.16-rc5/drivers/hsi/controllers/omap_ssi_port.c:1017]: (style) Checking if unsigned variable 'irq' is less than zero.

Source code is

    omap_port->irq = platform_get_irq(pd, 0);
    if (omap_port->irq < 0) {

Comment 1 Andrey Utkin 2014-07-17 14:06:49 UTC

Thanks, patch submitted: https://patchwork.kernel.org/patch/4575561/