Bug 80441 - drivers/hsi/controllers: 2 * pointless test ?
Summary: drivers/hsi/controllers: 2 * pointless test ?
Status: NEW
Alias: None
Product: Drivers
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: drivers_other
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-17 12:41 UTC by David Binderman
Modified: 2014-07-17 14:06 UTC (History)
1 user (show)

See Also:
Kernel Version: 3.16-rc5
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description David Binderman 2014-07-17 12:41:26 UTC 
1.

[linux-3.16-rc5/drivers/hsi/controllers/omap_ssi.c:357]: (style) Checking if unsigned variable 'gdd_irq' is less than zero.

Source code is

    omap_ssi->gdd_irq = platform_get_irq_byname(pd, "gdd_mpu");
    if (omap_ssi->gdd_irq < 0) {

2.

[linux-3.16-rc5/drivers/hsi/controllers/omap_ssi_port.c:1017]: (style) Checking if unsigned variable 'irq' is less than zero.

Source code is

    omap_port->irq = platform_get_irq(pd, 0);
    if (omap_port->irq < 0) {
Comment 1 Andrey Utkin 2014-07-17 14:06:49 UTC 
Thanks, patch submitted: https://patchwork.kernel.org/patch/4575561/
Note You need to log in before you can comment on or make changes to this bug.