Bug 76751

Summary: perf/ui/browser.c:199: possible bad if test ?
Product: Tracing/Profiling Reporter: David Binderman (dcb314)
Component: Perf toolAssignee: Arnaldo Carvalho de Melo (acme)
Status: RESOLVED CODE_FIX    
Severity: normal CC: colin.pitrat+kernelbug, rjvbertin
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 3.15-rc5 Subsystem:
Regression: No Bisected commit-id:

Description David Binderman 2014-05-22 16:17:06 UTC 
[linux-3.15-rc5/tools/perf/ui/browser.c:199]: (warning) Comparison of a boolean expression with an integer other than 0 or 1.

Source code is

        while ((key == ui__question_window("Warning!", text,
                           "Press any key...",
                           timeout)) == K_RESIZE)

I suspect

        while ((key = ui__question_window("Warning!", text,
                           "Press any key...",
                           timeout)) == K_RESIZE)

might have been intended.
Comment 2 Colin Pitrat 2016-05-02 20:01:58 UTC 
*** Bug 105271 has been marked as a duplicate of this bug. ***