Bug 76751 - perf/ui/browser.c:199: possible bad if test ?
Summary: perf/ui/browser.c:199: possible bad if test ?
Status: RESOLVED CODE_FIX
Alias: None
Product: Tracing/Profiling
Classification: Unclassified
Component: Perf tool (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: Arnaldo Carvalho de Melo
URL:
Keywords:
: 105271 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-05-22 16:17 UTC by David Binderman
Modified: 2016-05-02 20:02 UTC (History)
2 users (show)

See Also:
Kernel Version: 3.15-rc5
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description David Binderman 2014-05-22 16:17:06 UTC 
[linux-3.15-rc5/tools/perf/ui/browser.c:199]: (warning) Comparison of a boolean expression with an integer other than 0 or 1.

Source code is

        while ((key == ui__question_window("Warning!", text,
                           "Press any key...",
                           timeout)) == K_RESIZE)

I suspect

        while ((key = ui__question_window("Warning!", text,
                           "Press any key...",
                           timeout)) == K_RESIZE)

might have been intended.
Comment 2 Colin Pitrat 2016-05-02 20:01:58 UTC 
*** Bug 105271 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.