Bug 4981
Summary: | changes in 2.6.12-rc1 causes ati-remote to act strange | ||
---|---|---|---|
Product: | Drivers | Reporter: | mdew (some.nzguy) |
Component: | Input Devices | Assignee: | Marco Rodrigues (gothicx) |
Status: | REJECTED WILL_NOT_FIX | ||
Severity: | normal | CC: | cmsj, protasnb, some.nzguy, vojtech |
Priority: | P2 | ||
Hardware: | i386 | ||
OS: | Linux | ||
Kernel Version: | 2.6.13-rc3 | Subsystem: | |
Regression: | --- | Bisected commit-id: | |
Attachments: |
revert KEY_ENTER change
fix TV/DVD/OK button Fix TV/DVD/OK button for 2.6.24 |
Description
mdew
2005-08-01 19:40:16 UTC
Created attachment 5469 [details]
revert KEY_ENTER change
Changes KEY_ENTER back to KEY_OK fixes ATI-Remote "OK" not-responding issue.
Regarding repeat rate - ati-remote does a lot of calculatioons based on HZ which probably only work properly with HZ=1000. I think the code should be changed to work based on milliseconds - no patch yet though. Created attachment 5489 [details]
fix TV/DVD/OK button
previous patch was incorrect, this patch fixes the TV/DVD and the 'OK' button
not responding issue, basically reverts 3 changes from 2.6.12-rc1
Is this bug fixed? No, this is not fixed, or at least not all of it is. I can't speak for the OK button not working as mine has been ok, however, I am seeing the repeat related problem on 2.6.15 (via Ubuntu dapper). Should that really be filed as a separate bug? There does seem to be a patch at http://lkml.org/lkml/2006/7/2/89 so perhaps this can be closed very soon :) seems even in 2.6.15, this bug still occurs.. the patch is still valid and works. The new key assignments (KEY_TV, KEY_DVD and KEY_OK) are not available using legacy keyboard driver in X. Please make sure you are using evdev X driver with your remote. Was the problem resolved? mdev: have you tried recent kernel using evdev (as stated in #8) and if so - was it working for you? Thanks. I think this bug is already fixed... as of 2.6.21 (haven't tested the latest, or evdev), strictly using the ati-remote driver in the kernel, I still had to apply the patch. Without the patch the buttons on the remote don't work. The buttons will not work unless using evdev-based inputs as KEY_OK, KEY_TV and TV_DVD is above 240 threshold and can not be emulated within boundaries of PS/2 protocol. Please try the evdev driver for X with it. What about repeat rate? Is it OK with the newer kernels? I see the patch appears to be in - hopefully the driver works for everyone now? fwiw the excessive repeating thing is mostly fixed, but I do still find that some key presses are interpreted as repeats a little too quickly, so maybe the window of time before repeating could be extended a little further? repeat_delay module parameter is your friend then Created attachment 14681 [details]
Fix TV/DVD/OK button for 2.6.24
Problem with the ati-remote buttons hasn't been fixed, Updated for 2.6.24.
Chris, did recommended in #16 work for you? Mdew, it seems like you were advised to use evdev. Have you been able to give it a try? considering the driver works fine (with the minor patch), I haven't considered evdev. Everything worked up to the changes of 2.6.12-rc1. Regardless if evdev works or not, the bug in ati-remote module is still there. The link in #11 has an explanation why reverting to old version is not desirable. Using evdev should be a solution, without breaking other hardware. I reported 2 bugs, the first was Hz repeat issue which has been fixed #11, the other bug was changing the key codes which broke my remote. This patch has *nothing* to do with #11 or Hz repeat problem. It only reverts the ati-remote back to a workable state. Dmitry, can you please comment on the #8? The patch in #17 obviously fixes remote buttons for mdew. |