Bug 4981 - changes in 2.6.12-rc1 causes ati-remote to act strange
changes in 2.6.12-rc1 causes ati-remote to act strange
Status: REJECTED WILL_NOT_FIX
Product: Drivers
Classification: Unclassified
Component: Input Devices
i386 Linux
: P2 normal
Assigned To: Marco Rodrigues
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-08-01 19:40 UTC by mdew
Modified: 2008-09-22 15:47 UTC (History)
4 users (show)

See Also:
Kernel Version: 2.6.13-rc3
Tree: Mainline
Regression: ---


Attachments
revert KEY_ENTER change (826 bytes, patch)
2005-08-01 22:13 UTC, mdew
Details | Diff
fix TV/DVD/OK button (1.53 KB, patch)
2005-08-03 03:23 UTC, mdew
Details | Diff
Fix TV/DVD/OK button for 2.6.24 (1.54 KB, patch)
2008-02-02 00:45 UTC, mdew
Details | Diff

Description mdew 2005-08-01 19:40:16 UTC
Distribution:

using 2.6.11 everything works fine, Upgrading too 2.6.13-rc3 I noticed 2 errors,

(1) When setting the HZ rating too 250 or 100 will cause the driver to
excessfully repeat keys/accelerate when pressing a button, making it
unusable :(

(2) the "Ok" button no longer works in anything after and including
2.6.12-rc1 (I've tested upto 2.6.13-rc3), 2.6.11 works fine. xbindkeys
doesnt register any "ok" key presses on 2.6.12-rc1 onwards.

2.6.11 xbindkeys responses (nothing shows up in -rc1)

mediabawx2:~# xbindkeys -mk
Press combination of keys or/and click under the window.
You can use one of the two lines after "NoCommand"
in $HOME/.xbindkeysrc to bind a key.

--- Press "q" to stop. ---
"NoCommand"
m:0x0 + c:36
Return
"NoCommand"
m:0x0 + c:36
Return


Thanks :)

Hardware Environment:

0000:00:00.0 Host bridge: VIA Technologies, Inc. VT8375 [KM266/KL266] Host Bridg
                                             e
0000:00:01.0 PCI bridge: VIA Technologies, Inc. VT8633 [Apollo Pro266 AGP]
0000:00:05.0 Multimedia audio controller: C-Media Electronics Inc CM8738 (rev 10
                                             )
0000:00:06.0 Unknown mass storage controller: Triones Technologies, Inc. HPT366/
                                             368/370/370A/372 (rev 04)
0000:00:07.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL-8139/8139C
                                             /8139C+ (rev 10)
0000:00:10.0 USB Controller: VIA Technologies, Inc. VT82xxxxx UHCI USB 1.1 Contr
                                             oller (rev 80)
0000:00:10.1 USB Controller: VIA Technologies, Inc. VT82xxxxx UHCI USB 1.1 Contr
                                             oller (rev 80)
0000:00:10.2 USB Controller: VIA Technologies, Inc. VT82xxxxx UHCI USB 1.1 Contr
                                             oller (rev 80)
0000:00:10.3 USB Controller: VIA Technologies, Inc. USB 2.0 (rev 82)
0000:00:11.0 ISA bridge: VIA Technologies, Inc. VT8235 ISA Bridge
0000:00:11.1 IDE interface: VIA Technologies, Inc. VT82C586A/B/VT82C686/A/B/VT82
                                             3x/A/C PIPC Bus Master IDE (rev 06)
0000:00:12.0 Ethernet controller: VIA Technologies, Inc. VT6102 [Rhine-II] (rev
                                              74)
0000:01:00.0 VGA compatible controller: nVidia Corporation NV17 [GeForce4 MX 440
                                             ] (rev a3)
mediabawx2:/usr/src/linux-2.6.11# lspci
0000:00:00.0 Host bridge: VIA Technologies, Inc. VT8375 [KM266/KL266] Host Bridge
0000:00:01.0 PCI bridge: VIA Technologies, Inc. VT8633 [Apollo Pro266 AGP]
0000:00:05.0 Multimedia audio controller: C-Media Electronics Inc CM8738 (rev 10)
0000:00:06.0 Unknown mass storage controller: Triones Technologies, Inc.
HPT366/368/370/370A/372 (rev 04)
0000:00:07.0 Ethernet controller: Realtek Semiconductor Co., Ltd.
RTL-8139/8139C/8139C+ (rev 10)
0000:00:10.0 USB Controller: VIA Technologies, Inc. VT82xxxxx UHCI USB 1.1
Controller (rev 80)
0000:00:10.1 USB Controller: VIA Technologies, Inc. VT82xxxxx UHCI USB 1.1
Controller (rev 80)
0000:00:10.2 USB Controller: VIA Technologies, Inc. VT82xxxxx UHCI USB 1.1
Controller (rev 80)
0000:00:10.3 USB Controller: VIA Technologies, Inc. USB 2.0 (rev 82)
0000:00:11.0 ISA bridge: VIA Technologies, Inc. VT8235 ISA Bridge
0000:00:11.1 IDE interface: VIA Technologies, Inc.
VT82C586A/B/VT82C686/A/B/VT823x/A/C PIPC Bus Master IDE (rev 06)
0000:00:12.0 Ethernet controller: VIA Technologies, Inc. VT6102 [Rhine-II] (rev 74)
0000:01:00.0 VGA compatible controller: nVidia Corporation NV17 [GeForce4 MX
440] (rev a3)
Comment 1 mdew 2005-08-01 22:13:36 UTC
Created attachment 5469 [details]
revert KEY_ENTER change

Changes KEY_ENTER back to KEY_OK fixes ATI-Remote "OK" not-responding issue.
Comment 2 Dmitry Torokhov 2005-08-02 06:56:02 UTC
Regarding repeat rate - ati-remote does a lot of calculatioons based on HZ 
which probably only work properly with HZ=1000. I think the code should be 
changed to work based on milliseconds - no patch yet though.
Comment 3 mdew 2005-08-03 03:23:58 UTC
Created attachment 5489 [details]
fix TV/DVD/OK button

previous patch was incorrect, this patch fixes the TV/DVD and the 'OK' button
not responding issue, basically reverts 3 changes from 2.6.12-rc1
Comment 4 Andrew Morton 2006-01-11 22:09:42 UTC
Is this bug fixed?
Comment 5 Chris Jones 2006-07-03 04:42:20 UTC
No, this is not fixed, or at least not all of it is. I can't speak for the OK
button not working as mine has been ok, however, I am seeing the repeat related
problem on 2.6.15 (via Ubuntu dapper).
Should that really be filed as a separate bug?
Comment 6 Chris Jones 2006-07-03 07:27:12 UTC
There does seem to be a patch at http://lkml.org/lkml/2006/7/2/89 so perhaps
this can be closed very soon :)
Comment 7 mdew 2006-07-06 00:21:46 UTC
seems even in 2.6.15, this bug still occurs.. the patch is still valid and works.
Comment 8 Dmitry Torokhov 2006-07-06 06:00:26 UTC
The new key assignments (KEY_TV, KEY_DVD and KEY_OK) are not available using 
legacy keyboard driver in X. Please make sure you are using evdev X driver with 
your remote.
Comment 9 Natalie Protasevich 2007-06-22 23:17:47 UTC
Was the problem resolved? 
mdev: have you tried recent kernel using evdev (as stated in #8) and if so - was it working for you?
Thanks.
Comment 10 Marco Rodrigues 2007-07-07 04:35:39 UTC
I think this bug is already fixed...
Comment 12 mdew 2007-07-10 18:15:36 UTC
as of 2.6.21 (haven't tested the latest, or evdev), strictly using the ati-remote driver in the kernel, I still had to apply the patch. Without the patch the buttons on the remote don't work.
Comment 13 Dmitry Torokhov 2007-07-11 06:43:19 UTC
The buttons will not work unless using evdev-based inputs as KEY_OK, KEY_TV and TV_DVD is above 240 threshold and can not be emulated within boundaries of PS/2 protocol. Please try the evdev driver for X with it.

What about repeat rate? Is it OK with the newer kernels?
Comment 14 Natalie Protasevich 2007-10-10 22:07:37 UTC
I see the patch appears to be in - hopefully the driver works for everyone now?
Comment 15 Chris Jones 2007-10-17 05:12:32 UTC
fwiw the excessive repeating thing is mostly fixed, but I do still find that some key presses are interpreted as repeats a little too quickly, so maybe the window of time before repeating could be extended a little further?
Comment 16 Dmitry Torokhov 2007-10-17 06:47:28 UTC
repeat_delay module parameter is your friend then
Comment 17 mdew 2008-02-02 00:45:57 UTC
Created attachment 14681 [details]
Fix TV/DVD/OK button for 2.6.24

Problem with the ati-remote buttons hasn't been fixed, Updated for 2.6.24.
Comment 18 Natalie Protasevich 2008-02-02 00:57:43 UTC
Chris, did recommended in #16 work for you?

Mdew, it seems like you were advised to use evdev. Have you been able to give it a try?
Comment 19 mdew 2008-02-02 01:14:24 UTC
considering the driver works fine (with the minor patch), I haven't considered evdev. Everything worked up to the changes of 2.6.12-rc1. Regardless if evdev works or not, the bug in ati-remote module is still there.
Comment 20 Natalie Protasevich 2008-02-02 02:48:05 UTC
The link in #11 has an explanation why reverting to old version is not desirable. Using evdev should be a solution, without breaking other hardware.
Comment 21 mdew 2008-02-02 10:56:21 UTC
I reported 2 bugs, the first was Hz repeat issue which has been fixed #11, the other bug was changing the key codes which broke my remote. This patch has *nothing* to do with #11 or Hz repeat problem. It only reverts the ati-remote back to a workable state.
Comment 22 Natalie Protasevich 2008-02-02 11:34:40 UTC
Dmitry, can you please comment on the #8? The patch in #17 obviously fixes remote buttons for mdew.

Note You need to log in before you can comment on or make changes to this bug.