Bug 3336

Summary: ACPI_FUNCTION_TRACE() missing return's
Product: ACPI Reporter: Robert Moore (Robert.Moore)
Component: OtherAssignee: Len Brown (lenb)
Status: CLOSED CODE_FIX    
Severity: normal CC: acpi-bugzilla
Priority: P2    
Hardware: i386   
OS: Linux   
Kernel Version: 2.6.8.1 Subsystem:
Regression: --- Bisected commit-id:
Attachments: patch against 2.6.8.1 ACPI tree

Description Robert Moore 2004-09-03 09:16:45 UTC 
I have noticed a problem within many of the Linux ACPI-related drivers.

When ACPI_FUNCTION_TRACE() is used, all return() statements within the 
function should use the ACPI return macros (return_ACPI_STATUS, etc.) instead 
of just a raw return. These return macros maintain the function nesting count 
(nesting count is incremented by ACPI_FUNCTION_TRACE, and decremented by the 
return macros.)

The nesting depth is very useful when analyzing execution traces of ACPI code.
Comment 1 Len Brown 2004-11-01 23:42:30 UTC 
Created attachment 3930 [details]
patch against 2.6.8.1 ACPI tree
Comment 2 Len Brown 2004-11-15 19:41:59 UTC 
Shipped in Linux 2.6.10-rc2 - closed.