Bug 3336 - ACPI_FUNCTION_TRACE() missing return's
ACPI_FUNCTION_TRACE() missing return's
Status: CLOSED CODE_FIX
Product: ACPI
Classification: Unclassified
Component: Other
i386 Linux
: P2 normal
Assigned To: Len Brown
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-09-03 09:16 UTC by Robert Moore
Modified: 2004-11-15 19:41 UTC (History)
1 user (show)

See Also:
Kernel Version: 2.6.8.1
Tree: Mainline
Regression: ---


Attachments
patch against 2.6.8.1 ACPI tree (12.27 KB, patch)
2004-11-01 23:42 UTC, Len Brown
Details | Diff

Description Robert Moore 2004-09-03 09:16:45 UTC
I have noticed a problem within many of the Linux ACPI-related drivers.

When ACPI_FUNCTION_TRACE() is used, all return() statements within the 
function should use the ACPI return macros (return_ACPI_STATUS, etc.) instead 
of just a raw return. These return macros maintain the function nesting count 
(nesting count is incremented by ACPI_FUNCTION_TRACE, and decremented by the 
return macros.)

The nesting depth is very useful when analyzing execution traces of ACPI code.
Comment 1 Len Brown 2004-11-01 23:42:30 UTC
Created attachment 3930 [details]
patch against 2.6.8.1 ACPI tree
Comment 2 Len Brown 2004-11-15 19:41:59 UTC
Shipped in Linux 2.6.10-rc2 - closed. 

Note You need to log in before you can comment on or make changes to this bug.