Bug 25812

Summary: 2.6.37-rc7: Regression: b43: crashes in hwrng_register()
Product: Drivers Reporter: Maciej Rutecki (maciej.rutecki)
Component: OtherAssignee: drivers_other
Status: CLOSED CODE_FIX    
Severity: normal CC: florian, linville, maciej.rutecki, rjw
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 2.6.37-rc7 Subsystem:
Regression: Yes Bisected commit-id:
Bug Depends on:    
Bug Blocks: 21782    

Description Maciej Rutecki 2010-12-29 10:28:58 UTC 
Subject    : 2.6.37-rc7: Regression: b43: crashes in hwrng_register()
Submitter  : "Mario 'BitKoenig' Holbe" <Mario.Holbe@tu-ilmenau.de>
Date       : 2010-12-28 13:32
Message-ID : slrnihjpnh.7t4.Mario.Holbe@darkside.dyn.samba-tng.org
References : http://marc.info/?l=linux-kernel&m=129354319002301&w=2

This entry is being used for tracking a regression from 2.6.36. Please don't
close it until the problem is fixed in the mainline.
Comment 1 Florian Mickler 2011-01-15 13:11:27 UTC 
commit 0735ac1f2551d9f9d356126aaf3b1110150918e6
Author: Herbert Xu <herbert@gondor.apana.org.au>
Date:   Fri Jan 7 14:48:57 2011 +1100

    hwrng: via_rng - Fix asm constraints
    
    The inline asm to invoke xstore did not specify the constraints
    correctly.  In particular, dx/di should have been marked as output
    registers as well as input as they're modified by xstore.
    
    Thanks to Mario Holbe for creating this patch and testing it.
    
    Tested-by: Mario 'BitKoenig' Holbe <Mario.Holbe@TU-Ilmenau.DE>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>