Bug 219212

Summary: ASUS Vivobook Go E1404GAB_E1404GA keyboard does not work
Product: Drivers Reporter: fcestrada (fcestrada)
Component: Input DevicesAssignee: acpi_config-other
Status: NEW ---    
Severity: normal CC: carnil, fcestrada, lenb, rafael, tamim
Priority: P3    
Hardware: Intel   
OS: Linux   
Kernel Version: Subsystem:
Regression: No Bisected commit-id:
Attachments: dmidecode full output
Fix Keyboard on Asus Vivobook Go E1404GAB

Description fcestrada 2024-08-29 21:14:13 UTC
Created attachment 306794 [details]
dmidecode full output

Hi,

I am raising this report to help a user (Livi Toro) from the Debian Spanish user support list [0].

Keyboard does not work on an Asus VivoBook Go 14 E1404GAB laptop [1], it does not work in Debian stable (linux 6.1.106), and it doesn't work either with the latest live-image (linux 6.10.6).

There are many similar issues, like #218929 [2], so based on that, we believe a similar patch would be required for this model.

$ sudo dmidecode (full output attached, showing only relevant information here)
System Information
        Manufacturer: ASUSTeK COMPUTER INC.
        Product Name: Vivobook Go E1404GAB_E1404GA
Base Board Information
        Manufacturer: ASUSTeK COMPUTER INC.
        Product Name: E1404GAB

$ sudo cat /sys/firmware/acpi/tables/DSDT > dsdt.dat
$ iasl -d dsdt.dat
$ grep -A 30 PS2K dsdt.dsl | grep IRQ -A 1
                IRQ (Level, ActiveLow, Exclusive, )
                    {1}

Would you mind to help us with a review of this information, and, (if you consider acceptable), propose a patch adding the following lines into the repository "drivers/acpi/resource.c" file?

	{
		/* Asus Vivobook Go E1404GAB_E1404GA */
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
			DMI_MATCH(DMI_BOARD_NAME, "E1404GAB"),
		},
	},

Any additional information required, do not hesitate to request it.

P.S. We did not report directly to Debian taking this [3] as precedent, but we plan to report there to keep them informed.

[0] https://lists.debian.org/debian-user-spanish/2024/08/msg00039.html
[1] https://linux-hardware.org/?probe=5a3dac80c0
[2] https://bugzilla.kernel.org/show_bug.cgi?id=218929
[3] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1078696#20

Thanks & have a nice day!
Comment 1 Tamim Khan 2024-09-01 14:18:28 UTC
fcestrada@proton.me: From the iasl output, I can confirm this laptop is affected by the IRQ override issue and that the proposed patch should fix the problem.

Do you happen to know if the user tried the patch and if it allowed their keyboard to work? Also, just to confirm, would you like me to propose a patch to get this added to kernel or were you going to do that after we had verified the laptop was affected?

Thanks,
Tamim
Comment 2 fcestrada 2024-09-02 01:59:14 UTC
(In reply to Tamim Khan from comment #1)
> Do you happen to know if the user tried the patch and if it allowed their
> keyboard to work? Also, just to confirm, would you like me to propose a
> patch to get this added to kernel or were you going to do that after we had
> verified the laptop was affected?

Hi Tamim,

Yes, your help would be very appreciated to generate and propose the patch to be included in the kernel officially. Any evidence or information you require, please do not hesitate to request it.

Thanks & have an excellent day ;-)
Comment 3 Tamim Khan 2024-09-02 12:52:44 UTC
Created attachment 306805 [details]
Fix Keyboard on Asus Vivobook Go E1404GAB

@fcestrada: For reference, I have attached a patch that can be applied to 6.8+ kernels. If possible, could you have the Livi try it out to see if it fixes the problem?

I will get this submitted to the mailing list later today

Thanks,
Tamim
Comment 4 Tamim Khan 2024-09-03 14:31:49 UTC
Looks like this will be getting merged into 6.12: https://lore.kernel.org/linux-acpi/CAJZ5v0gQj7bxbJPtVsCaQRzC-VN0JQWyx1KNqnKTS-v5dyzsSw@mail.gmail.com/T/#t

Tamim
Comment 5 fcestrada 2024-09-05 04:02:12 UTC
Thank you very much Tamim for your help, Livi Toro has confirmed the correct operation of the keyboard [0], so now we will track the patch until it arrives in the 6.12 version.

[0] https://lists.debian.org/debian-user-spanish/2024/09/msg00000.html