Bug 194261

Summary: fs/xfs/libxfs/xfs_ialloc.c xfs_dialloc return/fault return error
Product: File System Reporter: Michael (michael_allen_bond)
Component: XFSAssignee: FileSystem/XFS Default Virtual Assignee (filesystem_xfs)
Status: NEW ---    
Severity: normal    
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 4.10 Subsystem:
Regression: No Bisected commit-id:

Description Michael 2017-02-07 05:41:45 UTC 
In xfs_dialloc:
	if (start_agno == NULLAGNUMBER) {
	                *inop = NULLFSINO;
	--->            return 0;

    if (agno == start_agno) {
            *inop = NULLFSINO;
    --->    return noroom ? -ENOSPC : 0;



There seem to be multiple ambiguous returns in this function.  If the return values for NULLFSINO are 0 (no error code), how is this handled in the caller function? 

Found using static analysis tools