Bug 194261 - fs/xfs/libxfs/xfs_ialloc.c xfs_dialloc return/fault return error
Summary: fs/xfs/libxfs/xfs_ialloc.c xfs_dialloc return/fault return error
Status: NEW
Alias: None
Product: File System
Classification: Unclassified
Component: XFS (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: FileSystem/XFS Default Virtual Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-07 05:41 UTC by Michael
Modified: 2017-02-07 05:41 UTC (History)
0 users

See Also:
Kernel Version: 4.10
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Michael 2017-02-07 05:41:45 UTC 
In xfs_dialloc:
	if (start_agno == NULLAGNUMBER) {
	                *inop = NULLFSINO;
	--->            return 0;

    if (agno == start_agno) {
            *inop = NULLFSINO;
    --->    return noroom ? -ENOSPC : 0;



There seem to be multiple ambiguous returns in this function.  If the return values for NULLFSINO are 0 (no error code), how is this handled in the caller function? 

Found using static analysis tools
Note You need to log in before you can comment on or make changes to this bug.