Bug 9040

Summary:	s3c2440_clk_add disables inactive clocks
Product:	Platform Specific/Hardware	Reporter:	Alec Tsai (alec_tsai)
Component:	ARM	Assignee:	Ben Dooks (ben-linux)
Status:	CLOSED OBSOLETE
Severity:	low	CC:	alan, protasnb, yyyeer.bo
Priority:	P1
Hardware:	All
OS:	Linux
Kernel Version:	2.6.22	Subsystem:
Regression:	No	Bisected commit-id:

Description Alec Tsai 2007-09-19 06:29:09 UTC

Problem Description:

If we add the sanity check
    BUG_ON(!clk->usage);
before
    if ((--clk->usage) == 0)
in arch/arm/plat-s3c24xx/clock.c:clk_disable, this check gets triggered
by the two calls to clk_disable in
arch/arm/mach-s3c2440/clock.c:s3c2440_clk_add

Comment 1 Russell King 2007-09-22 09:34:13 UTC

This bug is for Ben Dooks to resolve, and I've pointed Ben at this bug.  However,
I can't assign it to him, nor add him as a CC.  Expect no further action from me
personally.

Comment 2 Natalie Protasevich 2007-11-28 18:46:31 UTC

Hopefully Ben knows this. I think this should be forwarded to ARM list, I'll try to do this.
Thanks.