Bug 5467

Summary: oops in usbcore with kernel 2.6.14-rc4 + gregkh-all-2.6.14-rc4.patch (18-Oct-2005 19:25)
Product: Drivers Reporter: Frieder B (linux-stuff)
Component: USBAssignee: Greg Kroah-Hartman (greg)
Status: CLOSED CODE_FIX    
Severity: normal CC: stern
Priority: P2    
Hardware: i386   
OS: Linux   
Kernel Version: 2.6.14-rc4 + gregkh-all-2.6.14-rc4.patch Subsystem:
Regression: --- Bisected commit-id:
Bug Depends on:    
Bug Blocks: 5089    
Attachments: dmesg-2.6.14-rc4-gregkh-patches
proc-bus-usb-devices
proc-bus-usb-devices_new
Fix Greg's endpoint attribute stuff

Description Frieder B 2005-10-19 09:41:59 UTC
sorry I
Comment 1 Frieder B 2005-10-19 09:43:16 UTC
Created attachment 6332 [details]
dmesg-2.6.14-rc4-gregkh-patches

complete dmesg-output
Comment 2 Greg Kroah-Hartman 2005-10-19 09:51:12 UTC
What type of device are you removing?
Comment 3 Alan Stern 2005-10-19 11:49:02 UTC
The log shows that it was a USB printer.

Frieder, can you attach the contents of /proc/bus/usb/devices with the printer
plugged in?
Comment 4 Frieder B 2005-10-19 14:42:03 UTC
first scenario:
the printer is on
the oops occurs during gentoo
Comment 5 Frieder B 2005-10-19 14:44:15 UTC
Created attachment 6334 [details]
proc-bus-usb-devices

in reply to  Comment #3
Comment 6 Frieder B 2005-10-19 14:50:25 UTC
Created attachment 6335 [details]
proc-bus-usb-devices_new

the other does not contain the required informations
Comment 7 Alan Stern 2005-10-20 07:41:51 UTC
Aha -- multiple altsettings!  Just as I thought.

Greg, this is the problem I warned about earlier.  Your endpoint-attribute sysfs
code doesn't work when altsettings get changed.
Comment 8 Greg Kroah-Hartman 2005-10-20 17:18:07 UTC
On Thu, Oct 20, 2005 at 07:44:44AM -0700, bugme-daemon@kernel-bugs.osdl.org wrote:
> Aha -- multiple altsettings!  Just as I thought.
> 
> Greg, this is the problem I warned about earlier.  Your endpoint-attribute
> sysfs
> code doesn't work when altsettings get changed.

Ok, then we need some usb core changes in order to handle this properly,
right?
Comment 9 Alan Stern 2005-10-21 12:41:36 UTC
Created attachment 6357 [details]
Fix Greg's endpoint attribute stuff

Greg: Somehow I _knew_ you were going to say that!  :-)

Frieder, see if this patch helps.  I wrote it for 2.6.14-rc4 plus
gregkh-all-2.6.14-rc4.patch.  My copy of gregkh-all is a little old, so let me
know if you have any trouble applying this patch.

Greg: Eww!  Don't you believe in wrapping lines before 80 columns or checking
for error returns from kzalloc etc.?
Comment 10 Frieder B 2005-10-21 15:43:17 UTC
Alan your patch applied fine and seems to fix the oops
thx