Bug 38052

Summary: Build failure in nouveau_acpi.c
Product: Drivers Reporter: Alexey Mishustin (halcon)
Component: StagingAssignee: drivers_staging (drivers_staging)
Status: RESOLVED CODE_FIX    
Severity: normal CC: alan, ecyoung, kernel, peter.sliepenbeek, rasmus.johnsen
Priority: P1    
Hardware: i386   
OS: Linux   
Kernel Version: 2.6.38-gentoo-r6 Subsystem:
Regression: Yes Bisected commit-id:
Attachments: kernel 2.6.38-r6 .config
CONFIG_ACPI_VIDEO build failure patch

Description Alexey Mishustin 2011-06-22 12:50:01 UTC
Created attachment 63162 [details]
kernel 2.6.38-r6 .config

Hi. I cannot compile a 2.6.38 kernel (and 2.6.37 too) with Nouveau support. I
always get the error.

  drivers/built-in.o: In function `nouveau_acpi_edid':
  (.text+0xd6a00): undefined reference to `acpi_video_get_edid'

Reproducible: Always

Steps to Reproduce:
1. Take my .config (or `zcat /proc/config.gz > /usr/src/linux/.config` with the
current Gentoo Minimal CD running and turn on Nouveau support)
2. make menuconfig
3. make && make modules_install

Actual Results:  
Kernel is not compiled because of error
  drivers/built-in.o: In function `nouveau_acpi_edid':
  (.text+0xd6a00): undefined reference to `acpi_video_get_edid'

Expected Results:  
Kernel is compiled

It is possible that Nouveau has not specified all dependencies properly in the
Kconfig.
Comment 1 Stratos Psomadakis 2011-06-22 13:20:51 UTC
Created attachment 63182 [details]
CONFIG_ACPI_VIDEO build failure patch

I think this could resolve the build failure. Any comments are welcome.
Comment 2 Alexey Mishustin 2011-06-22 19:19:26 UTC
I confirm, this patch resolves my problem. Thanks.
Comment 3 ecyoung 2012-03-30 00:51:10 UTC
See Gentoo Bug 372321
https://bugs.gentoo.org/show_bug.cgi?id=372321

This is happening again in kernel 3.2.12-gentoo  How long until this becomes an adopted patch?  The Gentoo dev has a good reason for forcing patch into here (See Comment 12 in the link above.
Comment 4 Alan 2012-08-24 14:53:26 UTC
We don't accept patches via bugzilla - so nobody is going to apply it just because it's referenced there.
Comment 5 Rasmus Johnsen 2013-02-21 21:47:19 UTC
This issue/bug is still valid in the new version 3.7.9.

http://bpaste.net/show/VkJUEoWaLkMjO93zikE7/

If you have set marked the NVIDIA(nouveau) driver in the kernel as (*) and still the make fails with these kind of errors: 
http://bpaste.net/show/VkJUEoWaLkMjO93zikE7/

because the ACPI_VIDEO is not per definition set to -*- but only set to -M-, so then you have to go around that and edit a lot of settings with manually (Y) before the ACPI_VIDEO is set to -*-.

Best Regards
Comment 6 Tom Wijsman 2013-06-08 11:59:59 UTC
(In reply to comment #1)
> Created an attachment (id=63182) [details]
> CONFIG_ACPI_VIDEO build failure patch
> 
> I think this could resolve the build failure. Any comments are welcome.

Have you submitted this patch to the mailing lists already? Could you please do?