Bug 3497

Summary:	ans lcd cannot compile
Product:	Platform Specific/Hardware	Reporter:	FRLinux (frlinux)
Component:	PPC-32	Assignee:	platform_ppc-32
Status:	RESOLVED CODE_FIX
Severity:	normal
Priority:	P2
Hardware:	i386
OS:	Linux
Kernel Version:	2.6.9-rc3	Subsystem:
Regression:	---	Bisected commit-id:
Attachments:	configuration file for powerbook g4 ppc

Description FRLinux 2004-10-01 07:26:03 UTC

Distribution: sourcemage Linux 0.9.1 
Hardware Environment: powerbook titanium g4 867mhz 
Software Environment: gcc 3.3.3 
Problem Description: cannot compile the ans lcd powermac driver anymore. 
 
  CC      drivers/macintosh/ans-lcd.o 
drivers/macintosh/ans-lcd.c:76: warning: `struct inode' declared inside 
parameter list 
drivers/macintosh/ans-lcd.c:76: warning: its scope is only this definition or 
declaration, which is probably not what you want 
drivers/macintosh/ans-lcd.c:117: warning: `struct inode' declared inside 
parameter list 
drivers/macintosh/ans-lcd.c:122: error: variable `anslcd_fops' has initializer 
but incomplete type 
drivers/macintosh/ans-lcd.c:123: error: unknown field `write' specified in 
initializer 
drivers/macintosh/ans-lcd.c:123: warning: excess elements in struct 
initializer 
drivers/macintosh/ans-lcd.c:123: warning: (near initialization for 
`anslcd_fops') 
drivers/macintosh/ans-lcd.c:124: error: unknown field `ioctl' specified in 
initializer 
drivers/macintosh/ans-lcd.c:124: warning: excess elements in struct 
initializer 
drivers/macintosh/ans-lcd.c:124: warning: (near initialization for 
`anslcd_fops') 
drivers/macintosh/ans-lcd.c:125: error: unknown field `open' specified in 
initializer 
drivers/macintosh/ans-lcd.c:125: warning: excess elements in struct 
initializer 
drivers/macintosh/ans-lcd.c:125: warning: (near initialization for 
`anslcd_fops') 
drivers/macintosh/ans-lcd.c: In function `anslcd_init': 
drivers/macintosh/ans-lcd.c:157: warning: passing arg 1 of `iounmap' discards 
qualifiers from pointer target type 
drivers/macintosh/ans-lcd.c: In function `anslcd_exit': 
drivers/macintosh/ans-lcd.c:180: warning: passing arg 1 of `iounmap' discards 
qualifiers from pointer target type 
drivers/macintosh/ans-lcd.c: At top level: 
drivers/macintosh/ans-lcd.c:122: error: storage size of `anslcd_fops' isn't 
known 
make[2]: *** [drivers/macintosh/ans-lcd.o] Error 1 
make[1]: *** [drivers/macintosh] Error 2 
make: *** [drivers] Error 2 
 
Steps to reproduce: 
compile the kernel with ans lcd powermac as Y then watch it error(1)

Comment 1 FRLinux 2004-10-01 07:27:16 UTC

Created attachment 3748 [details]
configuration file for powerbook g4 ppc

kernel .config file to reproduce the error.

Comment 2 Colin Leroy 2004-10-08 03:36:46 UTC

Fixed in BK

Comment 3 FRLinux 2004-10-11 08:04:02 UTC

Works with the latest patch, thanks :)
Steph