Bug 24562

please attach the full dmesg output.

please attach the output of "grep . /sys/devices/system/cpu/cpu*/cpufreq/*"

Created attachment 39712 [details]
2.6.36.1_dmesg

Created attachment 39722 [details]
2.6.36.1_cpufreq

Created attachment 39732 [details]
2.6.36.1_config

I'm confused about what the problem is.

 (In reply to comment #0)
> And a bit further down cores 4 and 5 are not seen by "powernow-k8":
>
no, at least I can not see the problem from the log below.
 
> powernow-k8: Found 1 AMD Phenom(tm) II X6 1090T Processor (6 cpu cores)
> (version 2.20.00)
> powernow-k8: Core Performance Boosting: on.
> powernow-k8:    0 : pstate 0 (3200 MHz)
> powernow-k8:    1 : pstate 1 (2400 MHz)
> powernow-k8:    2 : pstate 2 (1600 MHz)
> powernow-k8:    3 : pstate 3 (800 MHz)
> 
these are four different p-states, which are supported by all of the six cores.

This is confusing, this can be read as: core 0, currently on 3200 MHz, core 1 currently on 2400 MHz, etc, with cores 4 and 5 not seen.

But I do understand what you are saying. Nevertheless, could the list be rearranged to make this clearer?

Should we close the (bug) report?

Many thanks.

Created attachment 39962 [details]
patch: fix a poor KERN_INFO message in powernow_k8 driver

so you probably want a patch like this, right?
I'll send the patch out later.

Beautiful, thank you!

Beautiful, thank you.


On 13/12/10 08:02, bugzilla-daemon@bugzilla.kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=24562
>
>
>
>
>
> --- Comment #7 from Zhang Rui<rui.zhang@intel.com>   2010-12-13 08:02:53 ---
> Created an attachment (id=39962)
>   -->  (https://bugzilla.kernel.org/attachment.cgi?id=39962)
> patch: fix a poor KERN_INFO message in powernow_k8 driver
>
> so you probably want a patch like this, right?
> I'll send the patch out later.
>

oh, sorry, I rechecked the code and it seems that the first "0,1,2,3" is not redundant information.
Reassign this bug to cpufreq driver experts.

No worries, thanks.

> This is confusing, this can be read as: core 0, currently on 3200 MHz, core 1
> currently on 2400 MHz, etc, with cores 4 and 5 not seen.
I expect you mean the new message on "boostable" CPUs which is unrelated to the rest:
> powernow-k8: Core Performance Boosting: on.
can get mixed up with below:
> powernow-k8:    0 : pstate 0 (3200 MHz)
> powernow-k8:    1 : pstate 1 (2400 MHz)
especially the "Core performance" string by bad luck looks related:
Core Performance
0 :  pstate 0
1 :  pstate 1

I agree that this is a bit confusing and Rui's first part of the patch should be sufficient:
 			if (cpu_family == CPU_HW_PSTATE) {
 				printk(KERN_INFO PFX
-					"   %d : pstate %d (%d MHz)\n", j,
+					"   pstate %d (%d MHz)\n",
 					data->powernow_table[j].index,
 					data->powernow_table[j].frequency/1000);

In the other case this message:
> powernow-k8: Core Performance Boosting: on.
doesn't appear anyway and the message has another format and the bit removed by Rui has some meaning.

But this is a really minor bug.
I hope I do not forget about it and I will add Rui's first part if I have other cpufreq patches in the queue -> I set this one resolved already.

Thanks, Thomas. Yes I mean:

"I expect you mean the new message on "boostable" CPUs which is unrelated to the
rest ..."

I already tried Rui's patch and I was happy with it.

A commit referencing this bug has been merged for .39-rc1:

commit 9e91869544fc831d640cae1ffd0313b38657b593
Author: Thomas Renninger <trenn@suse.de>
Date:   Thu Mar 3 21:31:24 2011 +0100

    [CPUFREQ] powernow-k8: The table index is not worth displaying

I'm closing this, although I'm a little confused about this bug report... please post a note if this shouldn't be closed yet.