Bug 218350
Summary: | kernelshark-v2.3.0 crash because of assert failed in ksmodel_set_upper_edge | ||
---|---|---|---|
Product: | Tools | Reporter: | Benjamin Robin (benjarobin+kernel) |
Component: | Trace-cmd/Kernelshark | Assignee: | Default virtual assignee for Trace-cmd and kernelshark (tools_tracecmd_kernelshark) |
Status: | NEW --- | ||
Severity: | high | CC: | y.karadz |
Priority: | P3 | ||
Hardware: | All | ||
OS: | Linux | ||
Kernel Version: | Subsystem: | ||
Regression: | No | Bisected commit-id: | |
Attachments: |
Patch
Patch-v2 Patch-v2 Patch-v2 Patch-v2 |
Description
Benjamin Robin
2024-01-06 18:19:17 UTC
Created attachment 305693 [details]
Patch
Hi Benjamin, Thanks a lot for reporting the issue! Please test the attached pach and tell me if it fixes that problem that you see. Cheers, Yordan Hi Benjamin, Thanks a lot for reporting the issue! Please test the attached patch and tell me if it fixes that problem that you see. Cheers, Yordan Created attachment 305694 [details]
Patch-v2
Yes your patch works, thanks for the idea, but I really don't like keeping the
update() function in KsGLWidget class since it overrides QWidget::update() and
QWidget::update() is not virtual.
Also I prefer the new connection mechanism, but I failed to connect directly to
QWidget::update(), so I used a lambda.
So I made a new v2 patch
Created attachment 305695 [details]
Patch-v2
Updated patch, also rename update function
Created attachment 305696 [details]
Patch-v2
Fix bad commit
Created attachment 305697 [details]
Patch-v2
Sorry for the spam, updated patch (again) I used this time the proper way to realize the connect (which I did learn)
Great!!! Please send your patch to the mailing list (linux-trace-devel@vger.kernel.org) and I will be happy to take it. Y. Did send it, hopefully properly. Thanks |