Bug 217557

Summary: ASPM is not enabled on hotplugged devices
Product: Drivers Reporter: Kai-Heng Feng (kai.heng.feng)
Component: PCIAssignee: drivers_pci (drivers_pci)
Status: NEW ---    
Severity: normal CC: bagasdotme
Priority: P3    
Hardware: All   
OS: Linux   
Kernel Version: Subsystem:
Regression: No Bisected commit-id:
Attachments: dmesg
lspci preboot connected
lspci hotplugged

Description Kai-Heng Feng 2023-06-15 07:01:18 UTC
Created attachment 304431 [details]
dmesg
Comment 1 Kai-Heng Feng 2023-06-15 07:02:00 UTC
Created attachment 304432 [details]
lspci preboot connected
Comment 2 Kai-Heng Feng 2023-06-15 07:02:20 UTC
Created attachment 304433 [details]
lspci hotplugged
Comment 3 Bagas Sanjaya 2023-06-15 12:43:54 UTC
Can you describe this issue please?
Comment 4 Kai-Heng Feng 2023-06-16 01:49:38 UTC
For example, this is when device is connected preboot:
38:00.0 Ethernet controller [0200]: Intel Corporation Ethernet Controller (2) I225-LMvP [8086:5502] (rev 03)
...
        Capabilities: [a0] Express (v2) Endpoint, MSI 00
...
                LnkCtl: ASPM L1 Enabled; RCB 64 bytes, Disabled- CommClk+
                        ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-


This is when device is hotplugged:
38:00.0 Ethernet controller [0200]: Intel Corporation Ethernet Controller (2) I225-LMvP [8086:5502] (rev 03)
...
        Capabilities: [a0] Express (v2) Endpoint, MSI 00
...
                LnkCtl: ASPM Disabled; RCB 64 bytes, Disabled- CommClk+
                        ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-

ASPM should be enabled for hotplugged case, too.