Bug 216649

Summary:	Laptop Internal keyboard not working on ASUS VivoBook M5402RA on ubuntu 22.04
Product:	Drivers	Reporter:	Shy Examiner (examiner)
Component:	Input Devices	Assignee:	drivers_input-devices
Status:	RESOLVED CODE_FIX
Severity:	blocking	CC:	examiner, tamim
Priority:	P1
Hardware:	All
OS:	Linux
See Also:	https://bugzilla.kernel.org/show_bug.cgi?id=216158 https://bugzilla.kernel.org/show_bug.cgi?id=216579
Kernel Version:	5.15.0-52-generic	Subsystem:
Regression:	No	Bisected commit-id:
Attachments:	Applying this patch will fix the keyboard issue

Description Shy Examiner 2022-11-01 19:07:46 UTC

Created attachment 303118 [details]
Applying this patch will fix the keyboard issue

ASUS VivoBook S5602ZA laptop keyboard is not working with Ubuntu 22.04.

Please find the result of the execution of following commands:

cat /sys/firmware/acpi/tables/DSDT > dsdt.dat
iasl -d dsdt.dat
grep -A 30 PS2K dsdt.dsl | grep IRQ -A 1


Result:
                IRQ (Edge, ActiveLow, Shared, )
                    {1}

Which helped creating the attached patch that fixed the keyboard after applying it.

Related to the issues mentioned here:
https://bugzilla.kernel.org/show_bug.cgi?id=216158
https://bugzilla.kernel.org/show_bug.cgi?id=216579

Comment 1 Shy Examiner 2022-11-01 19:15:53 UTC

(In reply to Shy Examiner from comment #0)

> 
> ASUS VivoBook S5602ZA laptop keyboard is not working with Ubuntu 22.04.
> 


The problem is found on ASUS VivoBook **M5402RA**, but I've incorrectly mentioned(copy/paste) another model that is also affected.

Comment 2 Tamim Khan 2022-11-02 04:18:10 UTC

I think the following patch should have already fixed this for your laptop: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/acpi/resource.c?h=v5.15.76&id=3bb12efc5e4d2b237230a4c6919b6fcf81d61190.

Can you try to upgrade to the latest 5.15 kernel (5.15.76) or the 6.0 kernel and see if that fixes the problem?

Tamim

Comment 3 Shy Examiner 2022-12-01 16:53:33 UTC

(In reply to Tamim Khan from comment #2)
> I think the following patch should have already fixed this for your laptop:
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/
> drivers/acpi/resource.c?h=v5.15.
> 76&id=3bb12efc5e4d2b237230a4c6919b6fcf81d61190.
> 
> Can you try to upgrade to the latest 5.15 kernel (5.15.76) or the 6.0 kernel
> and see if that fixes the problem?
> 
> Tamim

After upgrading to ubuntu's kernel 5.15.0-60-generic, which should have the applied the above mentioned patch, it didn't recognize the keyboard.

Comment 4 Shy Examiner 2022-12-01 16:58:14 UTC

(In reply to Shy Examiner from comment #3)
> (In reply to Tamim Khan from comment #2)
> > I think the following patch should have already fixed this for your laptop:
> > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/
> > drivers/acpi/resource.c?h=v5.15.
> > 76&id=3bb12efc5e4d2b237230a4c6919b6fcf81d61190.
> > 
> > Can you try to upgrade to the latest 5.15 kernel (5.15.76) or the 6.0
> kernel
> > and see if that fixes the problem?
> > 
> > Tamim
> 
> After upgrading to ubuntu's kernel 5.15.0-60-generic, which should have the
> applied the above mentioned patch, it didn't recognize the keyboard.

The ubuntu kernel number is 5.15.0-56-generic, but I mistyped it in the previous reply.

Comment 5 Tamim Khan 2022-12-03 05:52:26 UTC

I think this is still 5.15.0 kernel, just with some additional patches. From what I can tell, from the diff (https://launchpad.net/ubuntu/+archive/primary/+sourcefiles/linux/5.15.0-56.62/linux_5.15.0-56.62.diff.gz) and the change logs (https://launchpad.net/ubuntu/jammy/+source/linux) I don't this kernel release includes the patch above.

I think you are going to need to manually compile a 5.15.76+ or 6.0 kernel to have this patch be included.

Comment 6 Shy Examiner 2023-01-10 19:49:26 UTC

(In reply to Tamim Khan from comment #5)
> I think this is still 5.15.0 kernel, just with some additional patches. From
> what I can tell, from the diff
> (https://launchpad.net/ubuntu/+archive/primary/+sourcefiles/linux/5.15.0-56.
> 62/linux_5.15.0-56.62.diff.gz) and the change logs
> (https://launchpad.net/ubuntu/jammy/+source/linux) I don't this kernel
> release includes the patch above.
> 
> I think you are going to need to manually compile a 5.15.76+ or 6.0 kernel
> to have this patch be included.

In the latest ubuntu kernel 5.15.0-57, which includes the above mentioned IRQ patch, the keyboard is working like charm. So this confirms your suggestion. I wonder if the other workaround patches regarding the keyboard problem on Ryzen 6000 cpus should be discarded, since the patch that you've suggested solves the main issue? Namely, I am pointing to these 2 bugs:
https://bugzilla.kernel.org/show_bug.cgi?id=216158
https://bugzilla.kernel.org/show_bug.cgi?id=216579

Comment 7 Tamim Khan 2023-01-11 00:37:12 UTC

Nope. Those patches correspond to laptops that are only intel based. As a result, their keyboards will not be fixed by the patch that fixes Ryzen laptops.