Bug 216494

Summary:	ubifs: bad space budget for do_rename when target inode's(block dev) link_count > 1
Product:	File System	Reporter:	Zhihao Cheng (chengzhihao1)
Component:	Other	Assignee:	fs_other
Status:	NEW ---
Severity:	normal
Priority:	P1
Hardware:	All
OS:	Linux
Kernel Version:	6.0.0-rc4	Subsystem:
Regression:	No	Bisected commit-id:
Attachments:	diff setup.sh

Description Zhihao Cheng 2022-09-16 06:29:28 UTC

CONFIG_UBIFS_FS=m
CONFIG_MTD_UBI=m
CONFIG_MTD_NAND_NANDSIM=m

1. Apply diff and compile kernel
2. ./setup.sh 1
3. dmesg
[   64.389859] <7475> budget: dd_growth 792
[   64.400945] <7475> disk: mod_dent 312 dirty_ino+data 488

budget 792 < disk 800 (312 + 488)

Comment 1 Zhihao Cheng 2022-09-16 06:29:57 UTC

Created attachment 301816 [details]
diff

Comment 2 Zhihao Cheng 2022-09-16 06:30:09 UTC

Created attachment 301817 [details]
setup.sh

Comment 3 Zhihao Cheng 2022-10-12 07:35:11 UTC

(In reply to Zhihao Cheng from comment #0)
> CONFIG_UBIFS_FS=m
> CONFIG_MTD_UBI=m
> CONFIG_MTD_NAND_NANDSIM=m
> 
> 1. Apply diff and compile kernel
> 2. ./setup.sh 1
> 3. dmesg
> [   64.389859] <7475> budget: dd_growth 792
> [   64.400945] <7475> disk: mod_dent 312 dirty_ino+data 488
> 
> budget 792 < disk 800 (312 + 488)

Note: The budget value is calculated after https://patchwork.ozlabs.org/project/linux-mtd/patch/20221011034732.45605-5-chengzhihao1@huawei.com/ applied.