Bug 215762
Summary: | sp5100-tco sp5100-tco: Watchdog hardware is disabled | ||
---|---|---|---|
Product: | Drivers | Reporter: | sander44 (ionut_n2001) |
Component: | Watchdog | Assignee: | drivers_watchdog (drivers_watchdog) |
Status: | RESOLVED WILL_NOT_FIX | ||
Severity: | high | CC: | mario.limonciello |
Priority: | P1 | ||
Hardware: | x86-64 | ||
OS: | Linux | ||
Kernel Version: | 5.17.0-next | Subsystem: | |
Regression: | No | Bisected commit-id: | |
Attachments: | dmesg 5.17.0-next |
Description
sander44
2022-03-27 17:01:11 UTC
Created attachment 300626 [details]
dmesg 5.17.0-next
I'm sorry; but what is the ask here? Is it a regression that it's disabled for you? Hi Mario Limonciello, I don't think it's necessary to start it. I think the loglevel in this case is too big. val = readl(SP5100_WDT_CONTROL(tco->tcobase)); if (val & SP5100_WDT_DISABLED) { dev_err(dev, "Watchdog hardware is disabled\n"); return -ENODEV; } dev_err, maybe is fine to dev_dbg or dev_warn. Submitted as: https://lore.kernel.org/linux-watchdog/20220509163304.86-1-mario.limonciello@amd.com/T/#u Per upstream discussion this will remain as it is now. |