Bug 215521
Summary: | error: 'struct tep_print_arg_string' has no member named 'offset' | ||
---|---|---|---|
Product: | Tools | Reporter: | Vitaly Chikunov (vt) |
Component: | Trace-cmd/Kernelshark | Assignee: | Default virtual assignee for Trace-cmd and kernelshark (tools_tracecmd_kernelshark) |
Status: | RESOLVED CODE_FIX | ||
Severity: | normal | CC: | rostedt |
Priority: | P1 | ||
Hardware: | All | ||
OS: | Linux | ||
Kernel Version: | 5.15 | Subsystem: | |
Regression: | No | Bisected commit-id: | |
Attachments: |
libtraceevent: Fix backward compatibility with tep_print_arg_string
libtraceevent: Fix backward compatibility with tep_print_arg_string |
Description
Vitaly Chikunov
2022-01-22 19:38:50 UTC
I tried to build trace-cmd, libtraceevent, and libtracefs using latest versions available in git repos, is that wrong? Did I miss something? Thanks for reporting this. You are right. I usually test to make sure the stable versions of trace-cmd still build, I must have missed this. I'll have to figure out how to fix this. -- Steve Created attachment 300309 [details]
libtraceevent: Fix backward compatibility with tep_print_arg_string
It appears that trace-cmd 2.9.6 referenced the tep_print_arg_string to get to the offset, which was removed by libtraceevent commit 512d7be1 ("libtraceevent: Add __rel_loc relative location attribute support"). Add the offset back to both tep_print_arg_string and to tep_print_arg_bitmask (yeah, it adds a hole in the structure), for backward compatibility.
Created attachment 300310 [details]
libtraceevent: Fix backward compatibility with tep_print_arg_string
It appears that trace-cmd 2.9.6 referenced the tep_print_arg_string to
get to the offset, which was removed by libtraceevent commit 512d7be1
("libtraceevent: Add __rel_loc relative location attribute support").
Add the offset back to both tep_print_arg_string and to
tep_print_arg_bitmask (yeah, it adds a hole in the structure), for
backward compatibility.
--
v2 - I accidentally added unrelated changes to the previous patch.
(In reply to Vitaly Chikunov from comment #1) > I tried to build trace-cmd, libtraceevent, and libtracefs using latest > versions available in git repos, is that wrong? Did I miss something? I uploaded a patch to be applied to libtraceevent 1.5.0. Can you add that and see if it fixes the issue for you? Thanks, -- Steve After applying this patch to libtraceevent, trace-cmd compiles successfully. Thanks! |