Bug 213879

Summary:	No RMI4 support for Lenovo Thinkpad T14 Gen1
Product:	Drivers	Reporter:	oscar
Component:	Input Devices	Assignee:	drivers_input-devices
Status:	NEW ---
Severity:	normal	CC:	bugzilla.kernel.org, devurandom, fkrueger, grzegorz.alibozek, joaodduarte, lynx1534, mario.limonciello, md, michal, miroslav.bendik, terry.bowman, vasyl.demin, zhulik.gleb
Priority:	P1
Hardware:	All
OS:	Linux
Kernel Version:	5.13.5-arch1-1	Subsystem:
Regression:	No	Bisected commit-id:

Description oscar 2021-07-27 12:23:02 UTC

Hello! This issue because I have encountered errors in multi-finger gestures recognition on my new Lenovo Thinkpad T14 Gen1 (AMD), which I thought could be solved by the use of the kernel parameter "psmouse.synaptics_intertouch=1". Unfortunately, this fails with the following dmesg lines:

> [    4.475303] psmouse serio1: synaptics: Trying to set up SMBus access
> [    4.478360] psmouse serio1: synaptics: SMbus companion is not ready yet

I think this may be due to the fact that, even though RMI4 support was recently enabled for one model of the Lenovo Thinkpad T14 Gen1 (LEN2068), it wasn't for my specific model (LEN2064). Could anything be done about this? Thanks in advance for reading!

Relevant (maybe) links:

- Commit with RMI4 support for LEN2068: https://github.com/torvalds/linux/commit/470d154a62c4ef22b4de384ae91798851c9631a7
- The bug I initially filed with libinput: https://gitlab.freedesktop.org/libinput/libinput/-/issues/624
- Users with similar issue: https://forums.lenovo.com/t5/Other-Linux-Discussions/T14-AMD-touchpad-InterTouch-RMI4-mode-support/m-p/5051935

Comment 1 joaodduarte 2021-12-17 20:23:23 UTC

Is there an update on this, please? I am also experiencing the same issue.

Comment 2 Miroslav Bendík 2022-01-05 18:08:52 UTC

On some AMD machines piix4 (SMBus) detects wrong address, because PM IO can be disabled on never processors. If this is in dmesg:

SMBus Host Controller at 0xff00

then probably this is prevents communication using SMBus: here is patch https://lore.kernel.org/all/20210715221828.244536-1-Terry.Bowman@amd.com/ 

This is not single problem. Second problem is, that rmi4 needs SMBus host notify. I don't know if AMD implements SMBus host notify. I have tried to implement host notify, but without success. On my machine after loading psmouse with intertouch and disabled checks GPIO pin 19/20 started generating events. Probably touchpad/trackpoint is on this machine connected to GPIO. More informations here: https://patchwork.kernel.org/project/linux-input/patch/CAPoEpV0ZSidL6aMXvB6LN1uS-3CUHS4ggT8RwFgmkzzCiYJ-XQ@mail.gmail.com/

Comment 3 Michał Kopeć 2023-12-06 17:32:23 UTC

Greetings,

I saw some work-in-progress patches created by Miroslav Bendik at https://lore.kernel.org/all/c9b0b147-2907-ff41-4f13-464b3b891c50@wisdomtech.sk/ , but no further messages in this thread. Unfortunately the patch no longer applies cleanly and I haven't managed to rebase / port the changes as of yet.

It seems the progress stalled due to lack of access to documentation. Are there any people from AMD and / or Synaptics that we can ping to hopefully get some progress done here? It's a rather big issue for me as an user of a ThinkPad T14 Gen1 AMD and I would love to help any way I can to push this forward.