Bug 209287

Summary: NSID of nvme_get_effects_log()
Product: IO/Storage Reporter: Huai-Cheng Kuo (hh81478072)
Component: NVMeAssignee: IO/NVME Virtual Default Assignee (io_nvme)
Status: NEW ---    
Severity: normal CC: kbusch
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: 5.4 Subsystem:
Regression: No Bisected commit-id:

Description Huai-Cheng Kuo 2020-09-16 08:13:50 UTC 
Hi, 

In nvme_get_effects_log(), the NVMe command will be submitted with nsid = NVME_NSID_ALL (0xFFFFFFFF) and log_page = NVME_LOG_CMD_EFFECTS (0x05).
In NVMe spec, this log page identifier (0x05) is used in controller scope, but NSID 0xFFFFFFFF is use in all the namespaces under the controller. 
So I think the NSID here should be 0x0 instead of 0xFFFFFFFF.

Best Regards,
Huai-Cheng Kuo
Comment 1 Keith Busch 2020-09-17 20:11:43 UTC 
Yeah, that looks correct to me.