Bug 209043

Summary:	ftrace self tests failing from 5.7+
Product:	Tracing/Profiling	Reporter:	Colin Ian King (colin.king)
Component:	Ftrace	Assignee:	Steven Rostedt (rostedt)
Status:	NEW ---
Severity:	blocking	CC:	a.kawashiro
Priority:	P1
Hardware:	Intel
OS:	Linux
Kernel Version:	5.7+	Subsystem:
Regression:	No	Bisected commit-id:
Attachments:	config-5.8.3-050803-generic config-5.9.0-rc2+ ftrace passed config Succeeded test log Result of `LOCALVERSION=-dev-master sudo make kselftest KCFLAGS="-W" CC="ccache gcc" -j 12 TARGETS="ftrace" 2>&1 \| tee kselftest.log`

Description Colin Ian King 2020-08-26 09:40:49 UTC

Ftrace regression tests in tools/testing/selftests/ftrace are picking up regressions in 5.7+ - not sure if these are kernel regressions or bugs in ftrace selftests.

I'm seeing the following ftrace test regresions:

5.9-rc2 test failures with ARM64 in a 4GM VM + 8 CPUs

Test 12, "Generic dynamic event - selective clear (compatibility)"
Test 39, "Kprobe event with comm arguments"
Test 40, "Kprobe event string type argument"
Test 41, "Kprobe event symbol argument"
Test 43, "Kprobe dynamic event with arguments"
Test 44, "Kprobes event arguments with types"
Test 45, "Kprobe event user-memory access"
Test 47, "Kprobe dynamic event with function tracer" 
Test 48, "Kprobe dynamic event - probing module"
Test 51, "Kretprobe dynamic event with arguments"

5.8.3, 5.7.17 test failures:
Test 45, "Kprobe event user-memory access"
Test 48, "Kprobe dynamic event - probing module"
Test 51, "Kretprobe dynamic event with arguments"

These tests were working fine when I tested with 5.4.60, 5.5.19, 5.6.19, so these are definite regressions

Comment 1 Colin Ian King 2020-08-26 11:35:37 UTC

Urgh, typo. It should be "AMD64", in a QEMU VM.

Comment 2 Colin Ian King 2020-08-26 15:10:50 UTC

I suspect I've got some config settings disabled. I wonder if the require config settings are described somewhere for these tests to work correctly?

Comment 3 Colin Ian King 2020-08-26 15:11:48 UTC

Created attachment 292173 [details]
config-5.8.3-050803-generic

Comment 4 Colin Ian King 2020-08-26 15:12:25 UTC

Created attachment 292175 [details]
config-5.9.0-rc2+

Comment 5 Colin Ian King 2020-09-01 14:02:47 UTC

Is it possible to have a copy of a config where all these tests pass?

Comment 6 Colin Ian King 2020-09-01 14:03:50 UTC

Make alldefconfig isn't producing passing results on amd64 for me either.

Comment 7 Akira Kawata 2022-02-05 09:58:52 UTC

I confirmed all ftrace related tests passed with `LOCALVERSION=-dev-master sudo make kselftest KCFLAGS="-W" CC="ccache clang-12" -j 12 TARGETS="ftrace"`. Commit is
0457e5153e0e8420134f60921349099e907264ca Merge: fc93310c67ff f3136c4ce7ac
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Fri Feb 4 16:28:11 2022 -0800
.

Comment 8 Steven Rostedt 2022-02-05 17:51:05 UTC

(In reply to Akira Kawata from comment #7)
> I confirmed all ftrace related tests passed with `LOCALVERSION=-dev-master
> sudo make kselftest KCFLAGS="-W" CC="ccache clang-12" -j 12
> TARGETS="ftrace"`. Commit is
> 0457e5153e0e8420134f60921349099e907264ca Merge: fc93310c67ff f3136c4ce7ac
> Author: Linus Torvalds <torvalds@linux-foundation.org>
> Date:   Fri Feb 4 16:28:11 2022 -0800
> .

Does this mean that we can close this bug?

-- Steve

Comment 9 Akira Kawata 2022-02-05 23:24:38 UTC

Created attachment 300400 [details]
ftrace passed config

Comment 10 Akira Kawata 2022-02-05 23:26:35 UTC

> Does this mean that we can close this bug?

I think so. I attached the succeded config.

Comment 11 Akira Kawata 2022-02-06 00:00:24 UTC

Created attachment 300401 [details]
Succeeded test log

Result of test here.
`LOCALVERSION=-dev-master sudo make kselftest KCFLAGS="-W" CC="ccache clang-12" -j 12 TARGETS="ftrace" 2>& | tee kselftest.log

Comment 12 Akira Kawata 2022-02-06 00:13:32 UTC

Ooops, I ran kselftest with old kernel. I will upload the correct log soon. Sorry.

Comment 13 Akira Kawata 2022-02-06 05:50:41 UTC

Created attachment 300402 [details]
Result of `LOCALVERSION=-dev-master sudo make kselftest KCFLAGS="-W" CC="ccache gcc" -j 12 TARGETS="ftrace" 2>&1 | tee kselftest.log`

I attached the correct one. All tests passed also.