Bug 207069
Summary: | "trace-cmd report -f" functionality different than expected | ||
---|---|---|---|
Product: | Tools | Reporter: | Sudip (sudipm.mukherjee) |
Component: | Trace-cmd/Kernelshark | Assignee: | Steven Rostedt (rostedt) |
Status: | RESOLVED CODE_FIX | ||
Severity: | normal | CC: | rostedt |
Priority: | P1 | ||
Hardware: | All | ||
OS: | Linux | ||
Kernel Version: | all | Subsystem: | |
Regression: | No | Bisected commit-id: |
Description
Sudip
2020-04-02 19:35:01 UTC
Hi Sudip, The documentation may be a bit confusing. I guess it should be changed. Perhaps the documentation should say: "This outputs the list of functions and their addresses that have been saved in the file" That is, the trace-cmd record reads /proc/kallsyms and this basically displays that from the file. I don't want to change the code to reflect the document, but change the document (man page) to reflect the code. Thoughts? Hi Steven, Agreed. Changing the documentation is the best way instead of changing how the software behaves. Maybe something like: "This outputs the list of functions and their addresses that have been saved in the file as read from /proc/kallsyms". I'd rather not mention kallsyms, as that's more of an implementation detail than what its used for. Just a list of all the functions that are mapped to an address is what I want to express. I guess thats ok. After a re-read of your original suggestion, that also looks ok. :) Fixed by commit: 142a41e3df8e ("trace-cmd: Explicitly state what trace-cmd report -f does") |