Bug 203269
Summary: | CIFS: block in wait_for_free_credits when open file for SMB1.0 - xfstests generic/531 | ||
---|---|---|---|
Product: | File System | Reporter: | Xiaoli Feng (fengxiaoli0714) |
Component: | CIFS | Assignee: | fs_cifs (fs_cifs) |
Status: | RESOLVED CODE_FIX | ||
Severity: | high | CC: | smfrench |
Priority: | P1 | ||
Hardware: | All | ||
OS: | Linux | ||
Kernel Version: | 5.1.0-rc3+ | Subsystem: | |
Regression: | No | Bisected commit-id: | |
Attachments: | kernel patch to cifs.ko to fix cause of hang reported here |
Description
Xiaoli Feng
2019-04-11 07:27:36 UTC
It's a regression issue. Testing pass on v4.9-rc8 but is failed on v5.0. Looks like a fairly simple bug Presumably the oplock break issue mentioned above is easy to workaround - "modprobe ifs enable_oplocks=N" but the problem seems to be that we are leaking 'credits' (or perhaps more accurately for SMB1 dialect would be to say we are leaking the active request count) one for every oplock break. Should be a fairly easy fix - the reason it probably wasn't noticed as much is due to discouraging the use of SMB1 due to security being worse in this very old dialect. I tested Ronnie's fix with the reproducer and it worked. Let us know if you see any other related problems. Created attachment 282369 [details]
kernel patch to cifs.ko to fix cause of hang reported here
|