Bug 202001

Summary:	Broken SDL1 support
Product:	Drivers	Reporter:	mail
Component:	Console/Framebuffers	Assignee:	James Simmons (jsimmons)
Status:	NEW ---
Severity:	normal
Priority:	P1
Hardware:	All
OS:	Linux
Kernel Version:	4.14.80-, 4.18.18-, 4.19	Subsystem:
Regression:	Yes	Bisected commit-id:

Description mail 2018-12-16 12:06:57 UTC

The recent changes in drivers/gpu/drm/drm_fb_helper.c turned SDL1 support into the broken state. This library requires exporting a video options, but they was removed from kernel as useless.

This is a patch for 4.19.9 kernel that reverses changes back: http://saahriktu.org/downloads/patches/linux-4.19.9_make_sdl1_working_again.patch.lzma .

Comment 1 mail 2018-12-20 09:54:47 UTC

Sorry, I was wrong. It's not so broken. Critical lines in SDL1 code has nothing to do with options directly. Only thing it's does is just calls the FBIOPUT_VSCREENINFO and checks returned value. This lines can be removed and all works fine.