Bug 200533
Summary: | Potential NULL pointer dereference when nla_nest_start() fails in net/ncsi/ncsi-netlink.c | ||
---|---|---|---|
Product: | Networking | Reporter: | Jason Wood (jasonwood2031) |
Component: | Other | Assignee: | Stephen Hemminger (stephen) |
Status: | RESOLVED CODE_FIX | ||
Severity: | normal | ||
Priority: | P1 | ||
Hardware: | All | ||
OS: | Linux | ||
Kernel Version: | v4.18-rc4 | Subsystem: | |
Regression: | No | Bisected commit-id: |
Description
Jason Wood
2018-07-18 07:37:13 UTC
Already fixed by commit 8daf1a2d7e40685054ebae680733d822ced6df62 Author: Colin Ian King <colin.king@canonical.com> Date: Mon Mar 26 12:27:12 2018 +0100 net/ncsi: check for null return from call to nla_nest_start The call to nla_nest_start calls nla_put which can lead to a NULL return so it's possible for attr to become NULL and we can potentially get a NULL pointer dereference on attr. Fix this by checking for a NULL return. Detected by CoverityScan, CID#1466125 ("Dereference null return") Fixes: 955dc68cb9b2 ("net/ncsi: Add generic netlink family") Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: David S. Miller <davem@davemloft.net> |