Bug 198293

Summary: astdrmfb: colors on VT are broken
Product: Drivers Reporter: Elimar Riesebieter (riesebie)
Component: Console/FramebuffersAssignee: James Simmons (jsimmons)
Status: NEW ---    
Severity: normal CC: ck+kernelbugzilla, vapier
Priority: P1    
Hardware: x86-64   
OS: Linux   
Kernel Version: 4.14.9, 4.15-rc? Subsystem:
Regression: No Bisected commit-id:
Attachments: Screenshot

Description Elimar Riesebieter 2017-12-27 20:49:17 UTC
Colours on vt's are broken. I.e. white is shown as red. If I $(fbgrab -c1 blo.png) the picture shows correct colors, though.

I tested 4.9.65 and 4.13.13 which are looking normal.

$ lsmod | grep ast
ast                    61440  1                                                                                                            
drm_kms_helper        147456  1 ast                                                                                                        
ttm                    98304  1 ast                                                                                                        
drm                   339968  4 ast,ttm,drm_kms_helper                                                                                     
i2c_algo_bit           16384  2 igb,ast

$ cat /proc/fb
0 astdrmfb

$ uname -r
4.14.9-toy-lxtec-amd64

# fbset
mode "1600x1200"
    geometry 1600 1200 1600 1200 32
    timings 0 0 0 0 0 0 0
    accel true
    rgba 8/16,8/8,8/0,0/0
endmode

Thanks in advance
Elimar
Comment 1 Elimar Riesebieter 2017-12-31 13:30:05 UTC
The bug is relevant for 4.15? too.

A bisect pointed me to:

b8e2b0199cc377617dc238f5106352c06dcd3fa2 is the first bad commit¬                                                                         
  commit b8e2b0199cc377617dc238f5106352c06dcd3fa2¬
  Author: Peter Rosin <peda@axentia.se>¬
  Date:   Tue Jul 4 12:36:57 2017 +0200¬
  ¬
      drm/fb-helper: factor out pseudo-palette
      The pseudo-palette has nothing to do with the crtc, so move it¬
      out of the crtc loop and update the palette once, then break out¬
      early.¬
  ____¬
      Signed-off-by: Peter Rosin <peda@axenita.se>¬
      Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>¬
      Link: http://patchwork.freedesktop.org/patch/msgid/1499164632-5582-2-git-send-email-peda@axentia.se

HTH
Elimar
Comment 2 Conrad Kostecki 2018-03-20 22:51:07 UTC
Created attachment 274827 [details]
Screenshot

I can confirm. All my colors with astdrmfb are wrong on VT..
Comment 3 Mike Frysinger 2018-06-08 18:49:53 UTC
probably a dupe of bug 198293, although this one has more info in it