Bug 12697
Summary: | ext4_journal_start() spews errors on readonly filesystem | ||
---|---|---|---|
Product: | File System | Reporter: | Alexandre Correa (alexandre) |
Component: | ext4 | Assignee: | fs_ext4 (fs_ext4) |
Status: | CLOSED PATCH_ALREADY_AVAILABLE | ||
Severity: | high | CC: | alexandre |
Priority: | P1 | ||
Hardware: | All | ||
OS: | Linux | ||
Kernel Version: | 2.6.28-4 | Subsystem: | |
Regression: | --- | Bisected commit-id: |
Description
Alexandre Correa
2009-02-12 11:12:26 UTC
-30 is EROFS I assume you've had some error that shut down the filesystem previously, can you look? This seems to ring a bell for me but can't remember for sure if it's fixed, yet. /* start a new transaction*/ handle = ext4_journal_start(inode, needed_blocks); if (IS_ERR(handle)) { ret = PTR_ERR(handle); printk(KERN_CRIT "%s: jbd2_start: " "%ld pages, ino %lu; err %d\n", __func__, wbc->nr_to_write, inode->i_ino, ret); dump_stack(); goto out_writepages; } we should maybe check for a shutdown fs here before we generate all these messages. Yes, it's fixed already in 2.6.29-rcX, and it's in the queue of patches that I'm preparing for 2.6.27 and 2.6.28. Thanks Ted, thought so but couldn't remember for sure :) |